feat(build): migrate to TS7 and TS7-oriented oxlint-tsgolint - #43691
feat(build): migrate to TS7 and TS7-oriented oxlint-tsgolint#43691hainenber wants to merge 3 commits into
oxlint-tsgolint#43691Conversation
Signed-off-by: hainenber <dotronghai96@gmail.com>
Code Review Agent Run #521711Actionable Suggestions - 0Additional Suggestions - 2
Review Details
Bito Usage GuideCommands Type the following command in the pull request comment and save the comment.
Refer to the documentation for additional commands. Configuration This repository uses Documentation & Help |
✅ Deploy Preview for superset-docs-preview ready!
To edit notification comments on pull requests, go to your Netlify project configuration. |
rusackas
left a comment
There was a problem hiding this comment.
@hainenber LGTM, thanks for taking this on! I ran the new toolchain locally against the whole docs tree and it lints clean, so the pre-commit hook shouldn't surprise anyone. One small cleanup, before or after merge: bito's two leftovers are legit... the globals devDependency lost its only consumer when eslint.config.js went away, and the oxlint.json override for that same deleted file is dead config now. Approving!
Signed-off-by: hainenber <dotronghai96@gmail.com>
feat(build): migrate to TS7 and TS7-oriented
oxlint-tsgolintSUMMARY
Migrate
docsproject to Typescript v7. However, in order to do so, thetypescript-eslint/*toolings are replaced by neweroxlintand associatedoxlint-tsgolint. Since the need for linting in this project is limited, we can have broader window to use this linter.Runs
yarn build && yarn serveand the built docs are all fine. Nothing out of ordinaryBEFORE/AFTER SCREENSHOTS OR ANIMATED GIF
N/A, expect no regression
TESTING INSTRUCTIONS
There will be a Netlify deployment for this PR, one can check there readily.
ADDITIONAL INFORMATION