Skip to content

feat(build): migrate to TS7 and TS7-oriented oxlint-tsgolint - #43691

Open
hainenber wants to merge 3 commits into
masterfrom
feat/upgrade-typescript-to-v7-in-docs
Open

feat(build): migrate to TS7 and TS7-oriented oxlint-tsgolint#43691
hainenber wants to merge 3 commits into
masterfrom
feat/upgrade-typescript-to-v7-in-docs

Conversation

@hainenber

Copy link
Copy Markdown
Contributor

feat(build): migrate to TS7 and TS7-oriented oxlint-tsgolint

SUMMARY

Migrate docs project to Typescript v7. However, in order to do so, the typescript-eslint/* toolings are replaced by newer oxlint and associated oxlint-tsgolint. Since the need for linting in this project is limited, we can have broader window to use this linter.

Runs yarn build && yarn serve and the built docs are all fine. Nothing out of ordinary

BEFORE/AFTER SCREENSHOTS OR ANIMATED GIF

N/A, expect no regression

TESTING INSTRUCTIONS

There will be a Netlify deployment for this PR, one can check there readily.

ADDITIONAL INFORMATION

  • Has associated issue:
  • Required feature flags:
  • Changes UI
  • Includes DB Migration (follow approval process in SIP-59)
    • Migration is atomic, supports rollback & is backwards-compatible
    • Confirm DB migration upgrade and downgrade tested
    • Runtime estimates and downtime expectations provided
  • Introduces new feature or API
  • Removes existing feature or API

Signed-off-by: hainenber <dotronghai96@gmail.com>
@dosubot dosubot Bot added dependencies:npm javascript Dependabot - Pull requests that update Javascript code labels Aug 30, 2026
@bito-code-review

bito-code-review Bot commented Aug 30, 2026

Copy link
Copy Markdown
Contributor

Code Review Agent Run #521711

Actionable Suggestions - 0
Additional Suggestions - 2
  • docs/eslint.config.js - 2
    • Unused dependency left behind · Line 25-25
      Deleting this file leaves the `globals` devDependency in `docs/package.json` unused — it was only imported here (line 25). The new `oxlint.json` uses `env: { builtin, browser, node }` instead. Consider removing `"globals": "^17.11.0"` to avoid a stale dependency.
    • Dead config override · Line 36-36
      After deleting this file, `docs/oxlint.json` still contains an overrides block matching `files: ["eslint.config.js"]` (line 140) to disable `typescript/no-require-imports`. That file no longer exists, so the override is dead config. Remove it to keep the oxlint config accurate.
Review Details
  • Files reviewed - 3 · Commit Range: 9b59ebf..9b59ebf
    • .pre-commit-config.yaml
    • docs/eslint.config.js
    • docs/yarn.lock
  • Files skipped - 4
    • docs/DOCS_CLAUDE.md - Reason: Filter setting
    • docs/oxlint.json - Reason: Filter setting
    • docs/package.json - Reason: Filter setting
    • docs/tsconfig.json - Reason: Filter setting
  • Tools
    • Whispers (Secret Scanner) - ✔︎ Successful
    • Detect-secrets (Secret Scanner) - ✔︎ Successful

Bito Usage Guide

Commands

Type the following command in the pull request comment and save the comment.

  • /review - Manually triggers an incremental AI Review.

  • /review full - Manually triggers a full AI Review.

  • /pause - Pauses automatic reviews on this pull request.

  • /resume - Resumes automatic reviews.

  • /resolve - Marks all Bito-posted review comments as resolved.

  • /abort - Cancels all in-progress reviews.

Refer to the documentation for additional commands.

Configuration

This repository uses Superset You can customize the agent settings here or contact your Bito workspace admin at evan@preset.io.

Documentation & Help

AI Code Review powered by Bito Logo

@github-actions github-actions Bot added doc Namespace | Anything related to documentation and removed dependencies:npm labels Aug 30, 2026
@netlify

netlify Bot commented Aug 30, 2026

Copy link
Copy Markdown

Deploy Preview for superset-docs-preview ready!

Name Link
🔨 Latest commit 036e2a3
🔍 Latest deploy log https://app.netlify.com/projects/superset-docs-preview/deploys/6a94dfa4fd54d50008959355
😎 Deploy Preview https://deploy-preview-43691--superset-docs-preview.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.
🤖 Make changes Run an agent on this branch

To edit notification comments on pull requests, go to your Netlify project configuration.

@rusackas
rusackas requested review from rusackas and sadpandajoe and removed request for sadpandajoe August 30, 2026 19:11

@rusackas rusackas left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@hainenber LGTM, thanks for taking this on! I ran the new toolchain locally against the whole docs tree and it lints clean, so the pre-commit hook shouldn't surprise anyone. One small cleanup, before or after merge: bito's two leftovers are legit... the globals devDependency lost its only consumer when eslint.config.js went away, and the oxlint.json override for that same deleted file is dead config now. Approving!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

doc Namespace | Anything related to documentation javascript Dependabot - Pull requests that update Javascript code size/XXL

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants