refactor: import from sqlalchemy.orm#41981
Open
hy144328 wants to merge 1 commit into
Open
Conversation
hy144328
requested review from
betodealmeida,
eschutho,
michael-s-molina,
mistercrunch and
sadpandajoe
as code owners
dosubot
Bot
added
change:backend
Codecov Report✅ All modified and coverable lines are covered by tests.
Additional details and impacted files@@ Coverage Diff @@
## master #41981 +/- ##
==========================================
- Coverage 64.23% 56.29% -7.94%
==========================================
Files 2744 2749 +5
Lines 153659 154281 +622
Branches 35233 35233
==========================================
- Hits 98706 86859 -11847
- Misses 53055 66595 +13540
+ Partials 1898 827 -1071
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Harness. 🚀 New features to boost your workflow:
|
![bito-code-review[bot]](https://avatars.githubusercontent.com/in/1061978?s=60&v=4){kind=small}
Contributor
There was a problem hiding this comment.
Code Review Agent Run #ac712a
Actionable Suggestions - 1
-
pytest.ini - 1
- Unmet migration prerequisite · Line 43-43
Review Details
-
Files reviewed - 102 · Commit Range:
ae7e0c4..ae7e0c4- pytest.ini
- superset/connectors/sqla/models.py
- superset/connectors/sqla/utils.py
- superset/migrations/shared/catalogs.py
- superset/migrations/shared/migrate_viz/base.py
- superset/migrations/shared/security_converge.py
- superset/migrations/versions/2016-04-25_08-54_c3a8f8611885_materializing_permission.py
- superset/migrations/versions/2016-06-07_12-33_d8bc074f7aad_add_new_field_is_restricted_to_.py
- superset/migrations/versions/2016-06-27_08-43_27ae655e4247_make_creator_owners.py
- superset/migrations/versions/2016-09-07_23-50_33d996bcc382_update_slice_model.py
- superset/migrations/versions/2016-09-22_11-31_eca4694defa7_sqllab_setting_defaults.py
- superset/migrations/versions/2017-01-24_12-31_db0c65b146bd_update_slice_model_json.py
- superset/migrations/versions/2017-02-08_14-16_a99f2f7c195a_rewriting_url_from_shortner_with_new_.py
- superset/migrations/versions/2017-12-08_08-19_67a6ac9b727b_update_spatial_params.py
- superset/migrations/versions/2017-12-17_11-06_21e88bc06c02_annotation_migration.py
- superset/migrations/versions/2018-02-13_08-07_e866bd2d4976_smaller_grid.py
- superset/migrations/versions/2018-04-03_08-19_130915240929_is_sqllab_viz_flow.py
- superset/migrations/versions/2018-04-10_11-19_bf706ae5eb46_cal_heatmap_metric_to_metrics.py
- superset/migrations/versions/2018-06-04_11-12_c5756bec8b47_time_grain_sqla.py
- superset/migrations/versions/2018-06-07_09-52_afb7730f6a9c_remove_empty_filters.py
- superset/migrations/versions/2018-06-13_10-20_4451805bbaa1_remove_double_percents.py
- superset/migrations/versions/2018-06-13_14-54_bddc498dd179_adhoc_filters.py
- superset/migrations/versions/2018-06-14_14-31_80a67c5192fa_single_pie_chart_metric.py
- superset/migrations/versions/2018-07-05_15-19_3dda56f1c4c6_migrate_num_period_compare_and_period_.py
- superset/migrations/versions/2018-07-19_23-41_c617da68de7d_form_nullable.py
- superset/migrations/versions/2018-07-20_15-31_7f2635b51f5d_update_base_columns.py
- superset/migrations/versions/2018-07-20_15-57_e9df189e5c7e_update_base_metrics.py
- superset/migrations/versions/2018-07-22_11-59_bebcf3fed1fe_convert_dashboard_v1_positions.py
- superset/migrations/versions/2018-07-26_11-10_c82ee8a39623_add_implicit_tags.py
- superset/migrations/versions/2018-08-01_11-47_7fcdcde0761c_.py
- superset/migrations/versions/2018-11-12_13-31_4ce8df208545_migrate_time_range_for_default_filters.py
- superset/migrations/versions/2018-12-11_22-03_fb13d49b72f9_better_filters.py
- superset/migrations/versions/2019-03-21_10-22_d94d33dbe938_form_strip.py
- superset/migrations/versions/2019-04-09_16-27_80aa3f04bc82_add_parent_ids_in_dashboard_layout.py
- superset/migrations/versions/2019-06-28_13-17_ab8c66efdd01_resample.py
- superset/migrations/versions/2019-07-15_12-00_190188938582_adding_unique_constraint_on_dashboard_slices_tbl.py
- superset/migrations/versions/2019-09-11_21-49_5afa9079866a_serialize_schema_permissions_py.py
- superset/migrations/versions/2019-09-19_13-40_258b5280a45e_form_strip_leading_and_trailing_whitespace.py
- superset/migrations/versions/2019-10-10_13-52_1495eb914ad3_time_range.py
- superset/migrations/versions/2019-11-06_15-23_78ee127d0d1d_reconvert_legacy_filters_into_adhoc.py
- superset/migrations/versions/2020-02-07_14-13_3325d4caccc8_dashboard_scoped_filters.py
- superset/migrations/versions/2020-03-25_10-42_f9a30386bd74_cleanup_time_grainularity.py
- superset/migrations/versions/2020-04-29_09-24_620241d1153f_update_time_grain_sqla.py
- superset/migrations/versions/2020-08-12_00-24_978245563a02_migrate_iframe_to_dash_markdown.py
- superset/migrations/versions/2020-09-24_12-04_3fbbc6e8d654_fix_data_access_permissions_for_virtual_.py
- superset/migrations/versions/2020-09-28_17-57_b56500de1855_add_uuid_column_to_import_mixin.py
- superset/migrations/versions/2020-10-05_18-10_af30ca79208f_collapse_alerting_models_into_a_single_.py
- superset/migrations/versions/2020-10-21_21-09_96e99fb176a0_add_import_mixing_to_saved_query.py
- superset/migrations/versions/2021-01-23_16-25_260bf0649a77_migrate_x_dateunit_in_time_range.py
- superset/migrations/versions/2021-02-04_09-34_070c043f2fdb_add_granularity_to_charts_where_missing.py
- superset/migrations/versions/2021-02-10_12-32_41ce8799acc3_rename_pie_label_type.py
- superset/migrations/versions/2021-02-14_11-46_1412ec1e5a7b_legacy_force_directed_to_echart.py
- superset/migrations/versions/2021-03-24_09-47_989bbe479899_rename_filter_configuration_in_.py
- superset/migrations/versions/2021-04-07_07-21_134cea61c5e7_remove_dataset_health_check_message.py
- superset/migrations/versions/2021-04-09_16-14_085f06488938_country_map_use_lowercase_country_name.py
- superset/migrations/versions/2021-04-12_12-38_fc3a3a8ff221_migrate_filter_sets_to_new_format.py
- superset/migrations/versions/2021-04-29_15-32_f1410ed7ec95_migrate_native_filters_to_new_schema.py
- superset/migrations/versions/2021-08-02_16-39_e323605f370a_fix_schemas_allowed_for_csv_upload.py
- superset/migrations/versions/2021-08-03_15-36_143b6f2815da_migrate_pivot_table_v2_heatmaps_to_new_.py
- superset/migrations/versions/2021-08-31_11-37_021b81fe4fbb_add_type_to_native_filter_configuration.py
- superset/migrations/versions/2021-09-27_11-31_60dc453f4e2e_migrate_timeseries_limit_metric_to_.py
- superset/migrations/versions/2021-10-12_11-15_32646df09c64_update_time_grain_sqla.py
- superset/migrations/versions/2021-11-11_04-18_0ca9e5f1dacd_rename_to_schemas_allowed_for_file_.py
- superset/migrations/versions/2021-12-10_19-25_bb38f40aa3ff_add_force_screenshot_to_alerts_reports.py
- superset/migrations/versions/2021-12-13_14-06_fe23025b9441_rename_big_viz_total_form_data_fields.py
- superset/migrations/versions/2021-12-17_16-56_31bb738bd1d2_move_pivot_table_v2_legacy_order_by_to_.py
- superset/migrations/versions/2022-03-02_09-20_b5a422d8e252_fix_query_and_saved_query_null_schema.py
- superset/migrations/versions/2022-03-02_16-41_7293b0ca7944_change_adhoc_filter_b_from_none_to_.py
- superset/migrations/versions/2022-04-01_14-38_a9422eeaae74_new_dataset_models_take_2.py
- superset/migrations/versions/2022-04-04_15-04_b0d0249074e4_deprecate_time_range_endpoints_v2.py
- superset/migrations/versions/2022-04-18_11-20_ad07e4fdbaba_rm_time_range_endpoints_from_qc_3.py
- superset/migrations/versions/2022-05-03_19-39_cbe71abde154_fix_report_schedule_and_log.py
- superset/migrations/versions/2022-05-18_16-07_e786798587de_delete_none_permissions.py
- superset/migrations/versions/2022-06-19_16-17_f3afaf1f11f0_add_unique_name_desc_rls.py
- superset/migrations/versions/2022-06-27_14-59_7fb8bca906d2_permalink_rename_filterstate.py
- superset/migrations/versions/2022-07-05_15-48_409c7b420ab0_add_created_by_fk_as_owner.py
- superset/migrations/versions/2022-08-16_15-23_6d3c6f9d665d_fix_table_chart_conditional_formatting_.py
- superset/migrations/versions/2022-11-28_17-51_4ce1d9b25135_remove_filter_bar_orientation.py
- superset/migrations/versions/2023-02-28_14-46_c0a3ea245b61_remove_show_native_filters.py
- superset/migrations/versions/2023-03-05_10-06_d0ac08bb5b83_invert_horizontal_bar_chart_order.py
- superset/migrations/versions/2023-03-17_13-24_b5ea9d343307_bar_chart_stack_options.py
- superset/migrations/versions/2023-03-27_12-30_7e67aecbf3f1_chart_ds_constraint.py
- superset/migrations/versions/2023-05-01_12-03_9c2a5681ddfd_convert_key_value_entries_to_json.py
- superset/migrations/versions/2023-05-11_12-41_4ea966691069_cross_filter_global_scoping.py
- superset/migrations/versions/2023-07-18_15-30_863adcf72773_delete_obsolete_druid_nosql_slice_parameters.py
- superset/migrations/versions/2023-07-19_16-48_a23c6f8b1280_cleanup_erroneous_parent_filter_ids.py
- superset/migrations/versions/2023-07-19_17-54_ee179a490af9_deckgl_path_width_units.py
- superset/migrations/versions/2023-08-02_15-23_0769ef90fddd_fix_schema_perm_for_datasets.py
- superset/migrations/versions/2023-08-14_09-38_9f4a086c2676_add_normalize_columns_to_sqla_model.py
- superset/migrations/versions/2023-09-06_13-18_317970b4400c_added_time_secondary_column_to_.py
- superset/migrations/versions/2023-12-15_17-58_06dd9ff00fe8_add_percent_calculation_type_funnel_.py
- superset/migrations/versions/2024-01-18_15-20_214f580d09c9_migrate_filter_boxes_to_native_filters.py
- superset/migrations/versions/2024-03-01_10-47_be1b217cd8cd_big_number_kpi_single_metric.py
- superset/migrations/versions/2024-05-10_18-02_f84fde59123a_update_charts_with_old_time_comparison.py
- superset/migrations/versions/2025-04-13_22-10_378cecfdba9f_merge_x_axis_sort_series_with_x_axis_.py
- superset/migrations/versions/2025-06-06_00-39_363a9b1e8992_convert_metric_currencies_from_str_to_json.py
- superset/migrations/versions/2025-12-16_12-00_f5b5f88d8526_fix_form_data_string_in_query_context.py
- superset/models/helpers.py
- tests/integration_tests/base_tests.py
- tests/integration_tests/dao/base_dao_test.py
- tests/integration_tests/fixtures/datasource.py
- tests/unit_tests/dao/base_dao_test.py
-
Files skipped - 0
-
Tools
- MyPy (Static Code Analysis) - ✔︎ Successful
- Astral Ruff (Static Code Analysis) - ✔︎ Successful
- Whispers (Secret Scanner) - ✔︎ Successful
- Detect-secrets (Secret Scanner) - ✔︎ Successful
Bito Usage Guide
Commands
Type the following command in the pull request comment and save the comment.
-
/review- Manually triggers a full AI review. -
/pause- Pauses automatic reviews on this pull request. -
/resume- Resumes automatic reviews. -
/resolve- Marks all Bito-posted review comments as resolved. -
/abort- Cancels all in-progress reviews.
Refer to the documentation for additional commands.
Configuration
This repository uses Superset You can customize the agent settings here or contact your Bito workspace admin at evan@preset.io.
Documentation & Help
AI Code Review powered by
rusackas
approved these changes
Jul 13, 2026
hy144328
force-pushed
the
refactor/sqlalchemy-migration-declarative-base
branch
from
ae7e0c4 to
f910347
Compare
Contributor
Author
|
Force-pushed rebase to resolve merge conflicts. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
See #40273 .
SUMMARY
Enable errors on
declarative_base, and fix them all.In addition to fixing all broken tests, I manually went through all results of
git grep declarative_baseandgit grep sqlalchemy.ext.declarative.BEFORE/AFTER SCREENSHOTS OR ANIMATED GIF
TESTING INSTRUCTIONS
ADDITIONAL INFORMATION