[Improve] Replace SHA-256 password storage with PBKDF2#4352
Open
wolfboys wants to merge 1 commit into
Open
Conversation
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.



What changed
t_user.passwordfromvarchar(64)tovarchar(255)for PBKDF2 hash strings.ShaHashUtilsand keep legacy SHA-256 compatibility insidePasswordHashUtils.Why
The previous password storage used fast SHA-256 hashing, which is not appropriate for password storage and is vulnerable to offline brute-force attacks if the password
database is leaked.
PBKDF2-HMAC-SHA256 is available from the JDK, avoids adding new dependencies, and directly addresses the vulnerable password hashing behavior with minimal code and
dependency changes.