Skip to content

#2343 CollectionMetric: report the measurements as an ArrayList - #2344

Open
rzo1 wants to merge 1 commit into
mainfrom
collection-metric-kryo
Open

rzo1 wants to merge 1 commit into
mainfrom
collection-metric-kryo

Conversation

@rzo1

@rzo1 rzo1 commented Nov 16, 2026

Copy link
Copy Markdown
Contributor

Fixes #2343.

CollectionMetric (spout_query_time_msec of the querying spouts) reported its measurements as a LinkedList. Storm doesn't register LinkedList with Kryo, so with more than one worker and a V1 metrics consumer the spout executor died on Class is not registered: java.util.LinkedList and took its worker down.

getValueAndReset() now returns an ArrayList, which Storm registers. Same kind of problem as #2336.

CollectionMetricTest serializes the measurements with Kryo as Storm sets it up from its defaults, and checks that a LinkedList is rejected.

Found while testing 4.0.0 RC2 with an OpenSearch topology on 4 workers. Not a regression, 3.5.1 has the same code.

The measurements were reported as a LinkedList, which Storm does not
register with Kryo, so a V1 metrics consumer in another worker could not
receive them and the spout executor died.
@rzo1 rzo1 added this to the 4.0.1 milestone Nov 16, 2026
@rzo1
rzo1 requested review from dpol1 and jnioche November 16, 2026 17:57

This branch has not been deployed

No deployments
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

CollectionMetric: the measurements can't be serialized with Kryo

2 participants