Repository navigation
Conversation
The measurements were reported as a LinkedList, which Storm does not register with Kryo, so a V1 metrics consumer in another worker could not receive them and the spout executor died.
jnioche
approved these changes
Nov 16, 2026
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #2343.
CollectionMetric(spout_query_time_msecof the querying spouts) reported its measurements as aLinkedList. Storm doesn't registerLinkedListwith Kryo, so with more than one worker and a V1 metrics consumer the spout executor died onClass is not registered: java.util.LinkedListand took its worker down.getValueAndReset()now returns anArrayList, which Storm registers. Same kind of problem as #2336.CollectionMetricTestserializes the measurements with Kryo as Storm sets it up from its defaults, and checks that aLinkedListis rejected.Found while testing 4.0.0 RC2 with an OpenSearch topology on 4 workers. Not a regression, 3.5.1 has the same code.