Skip to content

#2340 Keep the archetype's .gitignore template in the source release - #2341

Merged
dpol1 merged 1 commit into
mainfrom
archetype-gitignore-source-release
Nov 16, 2026
Merged

dpol1 merged 1 commit into
mainfrom
archetype-gitignore-source-release

Conversation

@rzo1

@rzo1 rzo1 commented Nov 16, 2026

Copy link
Copy Markdown
Contributor

Fixes #2340.

  • assembly.xml: a fileSet of its own for archetype/src/main/resources/archetype-resources/.gitignore, without default excludes. The repository's own .gitignore stays out.
  • assembly.xml builds the zip as well. Until now the zip came from the ASF parent's source-release descriptor (the descriptorRefs merged into our execution), with its own default excludes, so the fix would have only reached the tar.gz. descriptorRefs combine.self="override" drops it.
  • .rat-excludes: **/.gitignore, for ATR's RAT run, like .gitattributes.

Checked with mvn -N -Papache-release package -Dgpg.skip: the zip is the same as before plus the .gitignore (the two symlinks are kept), and the tar.gz has the same files as the zip. -Prat verify -Dskip.format.code=false passes.

The default excludes of the assembly drop every .gitignore, including
the template the archetype copies into the projects it generates. It is
now added with a fileSet of its own. assembly.xml also builds the zip,
which came from the source-release descriptor of the ASF parent, so
that both archives have the same content.
@rzo1 rzo1 added this to the 4.0.0 milestone Nov 16, 2026
@rzo1
rzo1 requested review from dpol1 and jnioche November 16, 2026 09:14
@dpol1
dpol1 merged commit fac78d3 into main Nov 16, 2026
2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

The source release leaves out the archetype's .gitignore template

2 participants