Repository navigation
#2340 Keep the archetype's .gitignore template in the source release - #2341
Merged
Merged
Conversation
The default excludes of the assembly drop every .gitignore, including the template the archetype copies into the projects it generates. It is now added with a fileSet of its own. assembly.xml also builds the zip, which came from the source-release descriptor of the ASF parent, so that both archives have the same content.
dpol1
approved these changes
Nov 16, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #2340.
assembly.xml: a fileSet of its own forarchetype/src/main/resources/archetype-resources/.gitignore, without default excludes. The repository's own.gitignorestays out.assembly.xmlbuilds the zip as well. Until now the zip came from the ASF parent'ssource-releasedescriptor (thedescriptorRefsmerged into our execution), with its own default excludes, so the fix would have only reached the tar.gz.descriptorRefs combine.self="override"drops it..rat-excludes:**/.gitignore, for ATR's RAT run, like.gitattributes.Checked with
mvn -N -Papache-release package -Dgpg.skip: the zip is the same as before plus the.gitignore(the two symlinks are kept), and the tar.gz has the same files as the zip.-Prat verify -Dskip.format.code=falsepasses.