Repository navigation
#2336 StatusMetricsBolt: report the status counts as a HashMap - #2337
Merged
Merged
Conversation
The counts are kept in a ConcurrentHashMap, which Storm does not register with Kryo, so a V1 metrics consumer in another worker could not receive them and the status_metrics executor died. The gauge now returns a HashMap copy, as in 3.5.1.
jnioche
approved these changes
Nov 16, 2026
dpol1
approved these changes
Nov 16, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #2336.
StatusMetricsBoltkeeps its counts in aConcurrentHashMap(since #2242) and reported that map directly. Storm doesn't registerConcurrentHashMapwith Kryo, so with more than one worker and a V1 metrics consumer, thestatus_metricsexecutor died onClass is not registered: java.util.concurrent.ConcurrentHashMap.The gauge now returns a
HashMapcopy of the counts, as in 3.5.1. The map they are kept in stays concurrent, since the counts are updated from the async OpenSearch responses.StatusMetricsBoltTestserializes the counts with Kryo as Storm sets it up from its defaults, and checks that aConcurrentHashMapis rejected.Found while testing 4.0.0 RC1 on Storm 3.2.0 with 4 workers.