Repository navigation
Classify surviving deprecated APIs in storm-server, external modules, and utilities (#8994) - #9173
Open
Mohit20057 wants to merge 2 commits into
Open
Mohit20057 wants to merge 2 commits into
Mohit20057 wants to merge 2 commits into
Conversation
7 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What is the purpose of the change
Sub-task of umbrella issue #8994 ("inventory deprecated API and remove what is marked for removal").
This pull request classifies surviving
@Deprecateddeclarations acrossstorm-server,external/storm-hdfs,flux-core, and remainingstorm-clientutilities with explicitsince = "..."andforRemoval = true/falsedecisions to provide clear lifecycle signals to users and downstream consumers without introducing breaking removals:storm-server:Testing.java: Marked legacy test-cluster inspection and cluster lifecycle methodsforRemoval = true(since = "2.0.0").SchedulerAssignmentImpl.java: MarkedgetStatus()forRemoval = false(since = "2.0.0") as it remains in active use by the web UI and Nimbus scheduler APIs.BaseResourceAwareStrategy.java: Marked legacy scoring helper methodsforRemoval = true(since = "2.0.0").NodeSorter.java&NodeSorterHostProximity.java: Marked legacysortAllNodes(...)without cluster contextforRemoval = true(since = "2.4.0").External modules (
flux-core&storm-hdfs):Flux.java: Marked obsolete CLI option constants (OPTION_LOCAL,OPTION_REMOTE,OPTION_SLEEP,OPTION_ZOOKEEPER)forRemoval = true(since = "2.0.0").Configs.java: Marked 12 legacy HDFS spout configuration keysforRemoval = true(since = "2.0.0").HdfsState.java: MarkedHdfsFileOptions#addRotationAction(RotationAction)forRemoval = true(since = "2.0.0").storm-clientutilities & security:PlainSaslTransportPlugin.java,PlainClientCallbackHandler.java,SaslPlainServer.java: Added Javadoc deprecation notes and marked insecure test-only plain SASL provider classesforRemoval = true(since = "2.0.0").StormMetricRegistry.java: Markedgauge(..., port)overloadforRemoval = true(since = "2.3.0").StormReporter.java: Markedprepare(MetricRegistry, ...)forRemoval = true(since = "2.3.0").LinearDRPCTopologyBuilder.java: MarkedaddBolt(IRichBolt, ...)forRemoval = true(since = "2.0.0").How was this tested
storm-server,storm-client,storm-hdfs, andflux-corewith JDK 23storm-server:TestResourceAwareStrategy(14/14 tests passed)storm-client:TestConfigValidate(38/38 tests passed)external/storm-hdfs:ConfigsTest(2/2 tests passed)flux/flux-core:TCKTest#testTCK(1/1 tests passed)