Repository navigation
Formally mark Pacemaker subsystem and configs for removal (#8994) - #9171
Open
Mohit20057 wants to merge 1 commit into
Open
Mohit20057 wants to merge 1 commit into
Mohit20057 wants to merge 1 commit into
Conversation
7 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What is the purpose of the change
Part of Umbrella Issue #8994 (Sub-task 6: Inventory deprecated API and formalize deprecation decisions).
The Pacemaker subsystem was previously marked with
@Deprecatedand documentation stating that it is kept only for backward compatibility and will be removed in a future release, but lacked the formalsince = "3.1.0", forRemoval = trueattributes on its annotations.This PR upgrades the deprecation annotations to
@Deprecated(since = "3.1.0", forRemoval = true)across:storm-clientconfiguration keys:Config.PACEMAKER_SERVERSConfig.PACEMAKER_PORTConfig.PACEMAKER_CLIENT_MAX_THREADSConfig.PACEMAKER_AUTH_METHODConfig.PACEMAKER_THRIFT_MESSAGE_SIZE_MAXstorm-clientPacemaker classes:PaceMakerStateStoragePaceMakerStateStorageFactoryPacemakerClientPacemakerClientHandlerPacemakerClientPoolPacemakerConnectionExceptionThriftDecoderThriftEncoderThriftNettyClientCodecstorm-serverconfiguration keys:DaemonConfig.PACEMAKER_MAX_THREADSDaemonConfig.PACEMAKER_CHILDOPTSstorm-serverPacemaker classes:IServerMessageHandlerPacemakerPacemakerServerPacemakerServerHandlerThriftNettyServerCodecHow was the change tested
mvn test-compile -pl storm-client,storm-serverwith JDK 23:BUILD SUCCESS) and confirmed compiler deprecation warnings for removal across all modified items.storm-server:PacemakerServerTest,PacemakerTest,DaemonConfigTest(24/24 passed).storm-client:ThriftDecoderTest,PaceMakerStateStorageFactoryTest,TestConfigValidate(58/58 passed).Checklist