[SPARK-58546][ML] Avoid redundant StringIndexer label lookups - #57745
Closed
zhengruifeng wants to merge 2 commits into
Closed
[SPARK-58546][ML] Avoid redundant StringIndexer label lookups#57745zhengruifeng wants to merge 2 commits into
zhengruifeng wants to merge 2 commits into
Conversation
HyukjinKwon
approved these changes
Aug 4, 2026
zhengruifeng
added a commit
that referenced
this pull request
Aug 4, 2026
### What changes were proposed in this pull request? This PR passes `keepInvalid` into `StringIndexerModel.getIndexer`, computes it once during transformation, and uses one `OpenHashMap.get` lookup for non-null labels. ### Why are the changes needed? The previous UDF performed `contains` followed by map access for known labels, causing two lookups per value. This removes the redundant lookup while preserving invalid-label behavior. ### Does this PR introduce _any_ user-facing change? No. ### How was this patch tested? Not run (not requested). Verified with `git diff --check`, ASCII scan, and changed-line length scan. ### Was this patch authored or co-authored using generative AI tooling? Generated-by: Codex (GPT-5) Closes #57745 from zhengruifeng/single-lookup-string-indexer. Authored-by: Ruifeng Zheng <ruifengz@apache.org> Signed-off-by: Ruifeng Zheng <ruifengz@foxmail.com> (cherry picked from commit 1f2b47d) Signed-off-by: Ruifeng Zheng <ruifengz@foxmail.com>
Contributor
Author
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What changes were proposed in this pull request?
This PR passes
keepInvalidintoStringIndexerModel.getIndexer, computes it once during transformation, and uses oneOpenHashMap.getlookup for non-null labels.Why are the changes needed?
The previous UDF performed
containsfollowed by map access for known labels, causing two lookups per value. This removes the redundant lookup while preserving invalid-label behavior.Does this PR introduce any user-facing change?
No.
How was this patch tested?
Not run (not requested). Verified with
git diff --check, ASCII scan, and changed-line length scan.Was this patch authored or co-authored using generative AI tooling?
Generated-by: Codex (GPT-5)