[SPARK-58538][INFRA][4.3] Fix branch-4.3 workflow titles and default branch - #57740
Closed
HeartSaVioR wants to merge 1 commit into
Closed
[SPARK-58538][INFRA][4.3] Fix branch-4.3 workflow titles and default branch#57740HeartSaVioR wants to merge 1 commit into
HeartSaVioR wants to merge 1 commit into
Conversation
`branch-4.3` inherited its build workflows from `branch-4.x` when it was cut, so they are not yet prepared for the decoupled scheduler model. Apply what SPARK-58180 (apache#57319) did for `branch-4.2`, so a single scheduler on `master` can dispatch them: - remove the dormant `schedule:` triggers from the nine `build_*.yml` workflows, leaving `workflow_dispatch:`. Scheduled runs never fire from a non-default branch, so these crons were inert; the scheduler on `master` triggers them instead; - drop the branch token from the workflow titles, e.g. `"Build / Maven (branch-4.x, Scala 2.13, Hadoop 3, JDK 17)"` becomes `"Build / Maven (Scala 2.13, Hadoop 3, JDK 17)"`, matching the generic, non-branch-tagged names on `branch-4.2`. The old names also collided confusingly with the real `branch-4.x` runs in the Actions UI; - point the `branch` input default of both reusable workflows at this branch: `build_and_test.yml` from `branch-4.x` and `maven_test.yml` from `master`, both to `branch-4.3`, so the callers need no explicit `branch:`. The `maven_test.yml` default is the `branch-4.3` instance of SPARK-58537: the callers pass no `branch:` input, so the Maven workflows were building `master` rather than this branch. SPARK-58180 made the same `maven_test.yml` change for `branch-4.2` for the same reason. Co-authored-by: Isaac
HeartSaVioR
force-pushed
the
branch43-workflow-titles
branch
from
August 4, 2026 05:06
b20e5d2 to
79a32ad
Compare
zhengruifeng
approved these changes
Aug 4, 2026
HyukjinKwon
approved these changes
Aug 4, 2026
Contributor
Author
|
Thanks! Merging to 4.3. |
HeartSaVioR
added a commit
that referenced
this pull request
Aug 4, 2026
…branch ### What changes were proposed in this pull request? `branch-4.3` inherited its build workflows from `branch-4.x` when it was cut, so they still identify themselves as `branch-4.x`. Apply the convention that the other release branches (`branch-4.2`, `branch-4.1`) already follow: - drop the branch token from the nine `build_*.yml` workflow titles, e.g. `"Build / Maven (branch-4.x, Scala 2.13, Hadoop 3, JDK 17)"` becomes `"Build / Maven (Scala 2.13, Hadoop 3, JDK 17)"`. The branch is implied by where the file lives, and the old names collided confusingly with the real `branch-4.x` runs in the Actions UI and in check-run names; - point the `branch` input default of both reusable workflows at this branch: `build_and_test.yml` from `branch-4.x` and `maven_test.yml` from `master`, both to `branch-4.3`. The `maven_test.yml` default is the `branch-4.3` instance of SPARK-58537: the callers pass no `branch:` input, so the Maven workflows were building `master` rather than this branch. On `branch-4.2` and `branch-4.1` both reusable workflows default to their own branch, which is why their callers correctly need no explicit input. ### Why are the changes needed? branch-4.3 mistakenly refers to master branch in CI, which should have been fixed. ### Does this PR introduce _any_ user-facing change? No. ### How was this patch tested? scheduled CI will confirm with it. ### Was this patch authored or co-authored using generative AI tooling? Generated-by: Claude Opus 5 Closes #57740 from HeartSaVioR/branch43-workflow-titles. Authored-by: Jungtaek Lim <kabhwan.opensource@gmail.com> Signed-off-by: Jungtaek Lim <kabhwan.opensource@gmail.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What changes were proposed in this pull request?
branch-4.3inherited its build workflows frombranch-4.xwhen it was cut, so they still identify themselves asbranch-4.x. Apply the convention that the other release branches (branch-4.2,branch-4.1) already follow:build_*.ymlworkflow titles, e.g."Build / Maven (branch-4.x, Scala 2.13, Hadoop 3, JDK 17)"becomes"Build / Maven (Scala 2.13, Hadoop 3, JDK 17)". The branch is implied by where the file lives, and the old names collided confusingly with the realbranch-4.xruns in the Actions UI and in check-run names;branchinput default of both reusable workflows at this branch:build_and_test.ymlfrombranch-4.xandmaven_test.ymlfrommaster, both tobranch-4.3.The
maven_test.ymldefault is thebranch-4.3instance of SPARK-58537: the callers pass nobranch:input, so the Maven workflows were buildingmasterrather than this branch. Onbranch-4.2andbranch-4.1both reusable workflows default to their own branch, which is why their callers correctly need no explicit input.Why are the changes needed?
branch-4.3 mistakenly refers to master branch in CI, which should have been fixed.
Does this PR introduce any user-facing change?
No.
How was this patch tested?
scheduled CI will confirm with it.
Was this patch authored or co-authored using generative AI tooling?
Generated-by: Claude Opus 5