[SPARK-58537][INFRA][4.x] Make maven_test.yml default to branch-4.x on branch-4.x - #57739
Open
HeartSaVioR wants to merge 1 commit into
Open
[SPARK-58537][INFRA][4.x] Make maven_test.yml default to branch-4.x on branch-4.x#57739HeartSaVioR wants to merge 1 commit into
HeartSaVioR wants to merge 1 commit into
Conversation
…nch-4.x The scheduled Maven workflows on `branch-4.x` were building `master`, not the branch. They call the reusable `maven_test.yml` without passing a `branch` input, and that workflow declared `default: master`, which it then uses as the checkout ref. Five workflows on this branch rely on the default: `build_maven.yml`, `build_maven_java21.yml`, `build_maven_java25.yml`, `build_maven_java21_arm.yml` and `build_maven_java21_macos26.yml`. Point the default at `branch-4.x`, matching `build_and_test.yml` on this branch (already `branch-4.x`) and both reusable workflows on `branch-4.2` and `branch-4.1` (each defaulting to their own branch, which is why their callers correctly pass no input). Also retitle `build_maven_java21_arm.yml` and `build_maven_java21_macos26.yml`, which still said `master` in their names — a stale artifact of being copied from `master` (the same two are stale on `branch-4.2`). They ran against `master` only because of the default this commit fixes, so the names would otherwise become actively wrong. Callers that target another branch pass `branch:` explicitly (e.g. `build_branch41_maven.yml` passes `branch-4.1`) and are unaffected. This misreporting masked SPARK-57897, where `branch-4.x` could not load its Maven project model at all, yet the branch's Maven workflow kept reporting success. Co-authored-by: Isaac
zhengruifeng
approved these changes
Aug 4, 2026
Yicong-Huang
approved these changes
Aug 4, 2026
HyukjinKwon
approved these changes
Aug 4, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What changes were proposed in this pull request?
The scheduled Maven workflows on
branch-4.xwere buildingmaster, not the branch. They call the reusablemaven_test.ymlwithout passing abranchinput, and that workflow declareddefault: master, which it then uses as the checkout ref. Five workflows on this branch rely on the default:build_maven.yml,build_maven_java21.yml,build_maven_java25.yml,build_maven_java21_arm.ymlandbuild_maven_java21_macos26.yml.Point the default at
branch-4.x, matchingbuild_and_test.ymlon this branch (alreadybranch-4.x) and both reusable workflows onbranch-4.2andbranch-4.1(each defaulting to their own branch, which is why their callers correctly pass no input).Also retitle
build_maven_java21_arm.ymlandbuild_maven_java21_macos26.yml, which still saidmasterin their names — a stale artifact of being copied frommaster(the same two are stale onbranch-4.2). They ran againstmasteronly because of the default this commit fixes, so the names would otherwise become actively wrong.Callers that target another branch pass
branch:explicitly (e.g.build_branch41_maven.ymlpassesbranch-4.1) and are unaffected.This misreporting masked SPARK-57897, where
branch-4.xcould not load its Maven project model at all, yet the branch's Maven workflow kept reporting success.Why are the changes needed?
branch-4.x refers to master branch on CI which ended up with missing Maven build failure.
Does this PR introduce any user-facing change?
No
How was this patch tested?
scheduled CI will confirm with it.
Was this patch authored or co-authored using generative AI tooling?
Generated-by: Claude Opus 5