Skip to content

[SPARK-58534][BUILD][FOLLOWUP] Add 4.4 MiMa excludes section to master - #57738

Closed
HeartSaVioR wants to merge 1 commit into
apache:masterfrom
HeartSaVioR:master-mima-4.4
Closed

[SPARK-58534][BUILD][FOLLOWUP] Add 4.4 MiMa excludes section to master#57738
HeartSaVioR wants to merge 1 commit into
apache:masterfrom
HeartSaVioR:master-mima-4.4

Conversation

@HeartSaVioR

Copy link
Copy Markdown
Contributor

What changes were proposed in this pull request?

Follow-up to the branch-4.x version bump to 4.4.0, applied to master's MimaExcludes:

  • add v44excludes (built from v43excludes);
  • re-point v50excludes to build on v44excludes instead of v43excludes, so the chain is ... -> v43excludes -> v44excludes -> v50excludes;
  • add the case v if v.startsWith("4.4") => v44excludes arm to excludes(version).

Mirrors SPARK-56740's follow-up (#56510), which added the 4.3 section to master after branch-4.x was bumped to 4.3.0 by SPARK-57443.

Why are the changes needed?

Without this, master's exclude chain skips 4.4 and excludes("4.4.0") falls through to case _ => Seq(), returning no excludes at all.

Does this PR introduce any user-facing change?

No

How was this patch tested?

CI will test this out.

Was this patch authored or co-authored using generative AI tooling?

Generated-by: Claude Opus 5

Follow-up to the `branch-4.x` version bump to 4.4.0, applied to `master`'s
`MimaExcludes`:

- add `v44excludes` (built from `v43excludes`);
- re-point `v50excludes` to build on `v44excludes` instead of `v43excludes`,
  so the chain is `... -> v43excludes -> v44excludes -> v50excludes`;
- add the `case v if v.startsWith("4.4") => v44excludes` arm to
  `excludes(version)`.

Without this, `master`'s exclude chain skips 4.4 and `excludes("4.4.0")`
falls through to `case _ => Seq()`, returning no excludes at all.

Mirrors SPARK-56740's follow-up (apache#56510), which added the 4.3 section to
`master` after `branch-4.x` was bumped to 4.3.0 by SPARK-57443.

Co-authored-by: Isaac
@HeartSaVioR

Copy link
Copy Markdown
Contributor Author

Thanks! Merging to master.

@HeartSaVioR

Copy link
Copy Markdown
Contributor Author

Merge Summary:

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants