[SPARK-58513][CORE] Init UnifiedMemeoryManager should check driver config in driver , check executor config in executor - #57716
Open
AngersZhuuuu wants to merge 4 commits into
Open
Conversation
…nfig in driver , check executor config in executor
uros-b
approved these changes
Aug 3, 2026
Member
|
Thank you @AngersZhuuuu! |
Contributor
Author
|
This fix have a problem that may cause gluten failed to init, since we change teh method's parameter. So there have two way to fix this:
Which one do you think is better? @uros-b |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What changes were proposed in this pull request?
This patch updates UnifiedMemoryManager to validate memory according to the current process role.
Why are the changes needed?
When spark.executor.memory is set to 500m, the Executor may fail with the following error:
The error is misleading because UnifiedMemoryManager is initialized in the Executor, but the shared validation logic checks the runtime system memory as Driver memory and reports Driver-specific configuration guidance.
The Executor should validate its own executor memory configuration instead of applying the Driver memory check.
Does this PR introduce any user-facing change?
Yes.
Previously, an Executor could report a Driver memory error when its runtime system memory was below the Driver threshold.
After this change:
How was this patch tested?
Added UT
Was this patch authored or co-authored using generative AI tooling?
Yea