[SPARK-58555] Add new tests for JDBC DS Join pushdown - #57714
Open
urosstan-db wants to merge 2 commits into
Open
[SPARK-58555] Add new tests for JDBC DS Join pushdown#57714urosstan-db wants to merge 2 commits into
urosstan-db wants to merge 2 commits into
Conversation
urosstan-db
changed the title
urosstan-db
force-pushed
the
urosstan-db/additional-join-tests
branch
from
August 3, 2026 09:09
77473cf to
c0e1a12
Compare
urosstan-db
force-pushed
the
urosstan-db/additional-join-tests
branch
from
August 3, 2026 09:09
c0e1a12 to
6d82897
Compare
uros-b
reviewed
Aug 3, 2026
| sql(sqlQuery).collect().toSeq | ||
| } | ||
|
|
||
| assert(rowsNoPushdown.nonEmpty) |
Member
There was a problem hiding this comment.
These asserts don't seem to be doing much at the moment, please consider removing them.
Contributor
Author
There was a problem hiding this comment.
I added it as additional guard against modifications on test dataset, so I would like to preserve some guard against that (to make our test still relevant in the future), it is not requirement ofc. Do you maybe suggest we make assertion on entire result then, or asserting on number of rows, etc? Or totally removing it?
uros-b
reviewed
Aug 3, 2026
| sql(sqlQuery).collect().toSeq | ||
| } | ||
|
|
||
| assert(rowsNoPushdown.nonEmpty) |
Member
There was a problem hiding this comment.
uros-b
reviewed
Aug 3, 2026
uros-b
left a comment
uros-b
left a comment
Member
There was a problem hiding this comment.
Please add a Spark Jira ticket and component tag to the PR title.
urosstan-db
changed the title
Contributor
Author
Added now, sorry for not having the one initially |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What changes were proposed in this pull request?
Why are the changes needed?
Does this PR introduce any user-facing change?
No
How was this patch tested?
Test addtion/NA
Was this patch authored or co-authored using generative AI tooling?
No