[MINOR][PS][DOCS] Replace curly quotes with ASCII in pandas-on-Spark index comments#55559
Closed
zhengruifeng wants to merge 1 commit intoapache:masterfrom
Closed
[MINOR][PS][DOCS] Replace curly quotes with ASCII in pandas-on-Spark index comments#55559zhengruifeng wants to merge 1 commit intoapache:masterfrom
zhengruifeng wants to merge 1 commit intoapache:masterfrom
Conversation
zhengruifeng
changed the title
HyukjinKwon
approved these changes
Apr 27, 2026
Contributor
Author
|
merged to master |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What changes were proposed in this pull request?
Replaces left/right curly double quotes (U+201C/U+201D) with ASCII double quotes (U+0022) in four identical comments in pandas-on-Spark index modules:
python/pyspark/pandas/indexes/datetimes.py(2 sites)python/pyspark/pandas/indexes/multi.pypython/pyspark/pandas/indexes/base.pyEach comment reads
# so we enforce "distributed" default index type.Why are the changes needed?
The project convention is ASCII-only in code and comments; typographic quotes are a common slip and were flagged by
grep -P "[^\x00-\x7F]".Does this PR introduce any user-facing change?
No. Comment-only change.
How was this patch tested?
No tests. The change is comment-only and produces an empty AST diff. Verified
grep -P "[^\x00-\x7F]"no longer reports the four sites.Was this patch authored or co-authored using generative AI tooling?
Generated-by: Claude Code (model: claude-opus-4-7)