[SPARK-56591][SQL][TESTS][FOLLOWUP] Remove redundant QueryTest mixin from SharedSparkSession subclasses#55557
Closed
zhengruifeng wants to merge 2 commits intoapache:masterfrom
Closed
Conversation
…from SharedSparkSession subclasses ### What changes were proposed in this pull request? Follow-up to SPARK-56591. Seven additional `sql-core` test suites still mix in `QueryTest` alongside `SharedSparkSession` (which already extends `QueryTest`), so the explicit mixin is redundant. This removes the redundant `with QueryTest` and the now-unused `QueryTest` imports: - SchemaPruningSuite - ParquetRebaseDatetimeSuite - ParquetTypeWideningSuite - ParquetFileFormatSuite - FileSourceAggregatePushDownSuite - QueryCompilationErrorsSuite - QueryExecutionErrorsSuite ### Why are the changes needed? SPARK-56591 missed these cases. Removes redundant trait mixins so the `extends` lists faithfully describe the class hierarchy. ### Does this PR introduce _any_ user-facing change? No. Test-only class-declaration cleanup. ### How was this patch tested? Existing tests. (Local `sql/Test/compile` was attempted but blocked by an unrelated dependency-resolution failure for `io.netty:netty-tcnative-boringssl-static`; GitHub Actions CI on this PR will compile the affected modules.) ### Was this patch authored or co-authored using generative AI tooling? Generated-by: Claude Code (model: claude-opus-4-7)
`QueryErrorsBase` is a pure trait with no class ancestor, so making it the first member of `extends` left the superclass as `Object`, which conflicts with `SharedSparkSession`'s required `SparkFunSuite` superclass. Reorder to put `SharedSparkSession` first.
HyukjinKwon
approved these changes
Apr 27, 2026
Contributor
Author
|
merged to master |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What changes were proposed in this pull request?
Follow-up to SPARK-56591. Seven additional
sql-coretest suites still mix inQueryTestalongsideSharedSparkSession(which already extendsQueryTest), so the explicit mixin is redundant. This removes the redundantwith QueryTestand the now-unusedQueryTestimports:SchemaPruningSuiteParquetRebaseDatetimeSuiteParquetTypeWideningSuiteParquetFileFormatSuiteFileSourceAggregatePushDownSuiteQueryCompilationErrorsSuiteQueryExecutionErrorsSuiteWhy are the changes needed?
SPARK-56591 missed these cases. Removes redundant trait mixins so the
extendslists faithfully describe the class hierarchy.Does this PR introduce any user-facing change?
No. Test-only class-declaration cleanup.
How was this patch tested?
Existing tests. (Local
sql/Test/compilewas attempted but blocked by an unrelated dependency-resolution failure forio.netty:netty-tcnative-boringssl-static; GitHub Actions CI on this PR will compile the affected modules.)Was this patch authored or co-authored using generative AI tooling?
Generated-by: Claude Code (model: claude-opus-4-7)