[SPARK-56620][SQL] Fix stale entries in RuleIdCollection#55539
Open
huangxiaopingRD wants to merge 1 commit intoapache:masterfrom
Open
[SPARK-56620][SQL] Fix stale entries in RuleIdCollection#55539huangxiaopingRD wants to merge 1 commit intoapache:masterfrom
huangxiaopingRD wants to merge 1 commit intoapache:masterfrom
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What changes were proposed in this pull request?
This PR cleans up stale entries in RuleIdCollection by aligning rule names with the current Catalyst codebase.
Specifically, it updates/removes outdated rule FQNs in:
sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/rules/RuleIdCollection.scalaChanges made:
Replaced outdated rule name:
Replaced outdated Analyzer-scoped transpose rule name:
Removed stale rule entries that no longer exist as concrete rules:
Why are the changes needed?
RuleIdCollection is used to map repeatedly-invoked Catalyst rules to rule IDs for traversal pruning.
Keeping stale/non-existent entries causes drift between metadata and actual rule definitions, and makes maintenance/review harder.
This cleanup keeps RuleIdCollection consistent with current rule implementations and naming after multiple past refactors/renames.
Does this PR introduce any user-facing change?
No
How was this patch tested?
Verified that updated FQNs correspond to existing current rule definitions.
Verified that removed entries are stale and no longer map to active concrete rules.
Performed manual consistency review of the edited RuleIdCollection contents.
No new tests were added because this is an internal metadata cleanup without behavioral or API changes.
Was this patch authored or co-authored using generative AI tooling?
Generated-by: OpenAI Codex (GPT-5)