[SPARK-54665][PS] Fix boolean vs string comparison to match pandas behavior#54451
Closed
sfc-gh-dpetersohn wants to merge 1 commit intoapache:masterfrom
Closed
[SPARK-54665][PS] Fix boolean vs string comparison to match pandas behavior#54451sfc-gh-dpetersohn wants to merge 1 commit intoapache:masterfrom
sfc-gh-dpetersohn wants to merge 1 commit intoapache:masterfrom
Conversation
…havior Move _should_return_all_false type-mismatch check outside the ANSI mode guard in DataTypeOps.eq/ne and NumericOps.eq/ne so it always enforces pandas semantics regardless of spark.sql.ansi.enabled setting. Co-authored-by: Devin Petersohn <devin.petersohn@snowflake.com> Signed-off-by: Devin Petersohn <devin.petersohn@gmail.com>
Contributor
devin-petersohn
left a comment
devin-petersohn
left a comment
There was a problem hiding this comment.
I also changed ne even though it was not on the original bug report because the behavior was also broken.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What changes were proposed in this pull request?
Move the
_should_return_all_falsetype-mismatch check outside the ANSI mode guard inDataTypeOps.eq/neandNumericOps.eq/neso it runs regardless ofspark.sql.ansi.enabled.Why are the changes needed?
It is a bug, boolean vs string comparison doesn't match pandas behavior when ANSI mode is off.
Does this PR introduce any user-facing change?
Yes, fix the bug
How was this patch tested?
CI
Was this patch authored or co-authored using generative AI tooling?
Co-authored-by: Claude Opus 4