[SPARK-55606][CONNECT] Server-side implementation of GetStatus API#54445
Open
terana wants to merge 5 commits intoapache:masterfrom
Open
[SPARK-55606][CONNECT] Server-side implementation of GetStatus API#54445terana wants to merge 5 commits intoapache:masterfrom
terana wants to merge 5 commits intoapache:masterfrom
Conversation
hvanhovell
reviewed
Feb 24, 2026
| .createWithDefault(Nil) | ||
|
|
||
| val CONNECT_EXTENSIONS_GET_STATUS_CLASSES = | ||
| buildStaticConf("spark.connect.extensions.getStatus.classes") |
Contributor
There was a problem hiding this comment.
Does this mean a user can configure this from within the session? Is this something we desire?
hvanhovell
reviewed
Feb 24, 2026
| * the closed state itself does not convey why the operation ended, this value preserves that | ||
| * information for later use. | ||
| */ | ||
| private[connect] def terminationReason: Option[TerminationReason] = _terminationReason |
Contributor
There was a problem hiding this comment.
What is accessing this? And is this access happening from multiple threads? If so then _terminationReason should be volatile.
hvanhovell
reviewed
Feb 24, 2026
| case None => Seq.empty | ||
| } | ||
| } catch { | ||
| case e: Throwable => |
Contributor
There was a problem hiding this comment.
Please don't catch Throwable, that also covers JVM errors. Please use NonFatal instead.
hvanhovell
reviewed
Feb 24, 2026
| case None => Seq.empty | ||
| } | ||
| } catch { | ||
| case e: Throwable => |
hvanhovell
reviewed
Feb 24, 2026
Contributor
hvanhovell
left a comment
hvanhovell
left a comment
There was a problem hiding this comment.
A couple of small nits/questions. Otherwise LGTM.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What changes were proposed in this pull request?
Server-side implementation of the GetStatus API:
Why are the changes needed?
GetStatus API allows to monitor status of executions in a session, which is particularly useful in multithreaded clients.
Does this PR introduce any user-facing change?
Yes. It's a new Spark Connect API.
How was this patch tested?
Was this patch authored or co-authored using generative AI tooling?
Generated-by: Claude 4.6 Opus High