fix(tests): add missing main block to test_session.py#54426
Closed
machov wants to merge 1 commit intoapache:masterfrom
Closed
fix(tests): add missing main block to test_session.py#54426machov wants to merge 1 commit intoapache:masterfrom
machov wants to merge 1 commit intoapache:masterfrom
Conversation
Fixes apache#54405 The test_session.py file was missing the main block that allows it to be executed directly and included in CI runs. This follows the pattern established in other test files and resolves the issue where tests were not being executed.
Contributor
|
The problem is not that this test does not run - it's that the test fails. I skipped working on this because I'm not sure what the original author tries to validate. I already reached out to the original author of the test and hopefully he can fix the test itself. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #54405
The
test_session.pyfile was missing theif __name__ == '__main__'block that allows it to be executed directly and included in CI runs. This follows the pattern established in other test files throughout the codebase.This simple addition resolves the issue where these tests were not being executed in CI, ensuring better test coverage going forward.
Changes:
python/pyspark/sql/tests/connect/test_session.pymainfrompyspark.testing)Testing:
The file can now be executed directly with
python test_session.py.