[SPARK-54866][SQL] Refactor Drop/RefreshFunction to avoid catalog lookup #53638
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
cloud-fan
force-pushed
the
drop_func
branch
3 times, most recently
from
013ea84 to
4c5ef47
Compare
| val sessionCatalog = catalogManager.v1SessionCatalog | ||
| if (sessionCatalog.isBuiltinFunction(funcName)) { | ||
| val ident = Identifier.of(Array(CatalogManager.BUILTIN_NAMESPACE), nameParts.head) | ||
| ResolvedIdentifier(FakeSystemCatalog, ident) |
Contributor
There was a problem hiding this comment.
What is FakeSystemCatalog?
Contributor
Author
There was a problem hiding this comment.
It's a virtual catalog to help ResolvedIdentifier represent fully qualified names for temp/builtin objects. Otherwise the v2 command framework can't work with them. You can check the usage of FakeSystemCatalog, it has been used in a few places already.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What changes were proposed in this pull request?
DROP/REFRESH FUNCTION commands only need to know the qualified function name, or if the function is builtin/temp, then call catalog APIs to finish the work. This PR refactors
Drop/RefreshFunctionto useUnresolvedIdentifierandResolveIdentifier, followingDropTable, to eliminate the unnecessary catalog lookup.Why are the changes needed?
Save unnecessary catalog RPC for function lookup.
Does this PR introduce any user-facing change?
no
How was this patch tested?
existing tests
Was this patch authored or co-authored using generative AI tooling?
cursor 2.2.44