[MINOR][SQL] Change withTimeZone in Cast to only put it if needed #53623
+13
−19
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What changes were proposed in this pull request?
Change
withTimeZonefor Cast to only put the time zone if needed for casting.Why are the changes needed?
Analyzer is overeager, so it produces a stronger result (always put time zone for Cast) then needed for Cast to be marked as resolved (only need timezone if it is needed for cast). This causes problems when reanalyzing plan for single-pass analyzer.
Does this PR introduce any user-facing change?
No.
How was this patch tested?
cte-recursion with single pass, existing CIs.
Was this patch authored or co-authored using generative AI tooling?
No.