[SPARK-54852][SQL] NOT IN subquery returns incorrect results with a collated table
#53622
+208
−4
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What changes were proposed in this pull request?
When performing a hash join on collated columns, we first wrap the column with
CollationKeyduring analysis. This is because the hash ofCollationKeyis collation-aware. The problem with this query is that there is no join during the analysis phase (we haveNOT IN), and the join is added during the optimization phase. As a result, the join operates on raw columns, which are not collation-aware.This PR fixes the issue by rewriting the join keys in
HashJointrait.Why are the changes needed?
Bug fix.
Does this PR introduce any user-facing change?
No.
How was this patch tested?
New tests.
Was this patch authored or co-authored using generative AI tooling?
No.