Skip to content

[SPARK-54841][SQL] Make EstimationUtils#numBinsHoldingRange more accurate #53618

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
xunxunmimi5577 wants to merge 2 commits into
base: master
Choose a base branch
from
+4 −2
Open

[SPARK-54841][SQL] Make EstimationUtils#numBinsHoldingRange more accurate #53618

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
3979921
Make filer estimation more accurate with histogram
xunxunmimi5577 Dec 25, 2025
bbaa423
Merge branch 'apache:master' into make-numBinsHoldingRange-more-accurate
xunxunmimi5577 Dec 26, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 4 additions & 2 deletions ...n/scala/org/apache/spark/sql/catalyst/plans/logical/statsEstimation/EstimationUtils.scala
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -243,10 +243,12 @@ object EstimationUtils {
} else {
// Computes the occupied portion of bins of the upperBound and lowerBound.
val lowerBin = bins(lowerBinIndex)
val lowerPart = binHoldingRangePossibility(lowerBin.hi, lowerBound, lowerBin)
val lowerPart = if (lowerBin.hi == lowerBound && !lowerBoundInclusive) 0.0
else binHoldingRangePossibility(lowerBin.hi, lowerBound, lowerBin)

val higherBin = bins(upperBinIndex)
val higherPart = binHoldingRangePossibility(upperBound, higherBin.lo, higherBin)
val higherPart = if (higherBin.lo == upperBound && !upperBoundInclusive) 0.0
else binHoldingRangePossibility(upperBound, higherBin.lo, higherBin)

// The total number of bins is lowerPart + higherPart + bins between them
lowerPart + higherPart + upperBinIndex - lowerBinIndex - 1
Expand Down