SOLR-18417: Deprecate v1 PingRequestHandler and related code - #4872
Open
gerlowskija wants to merge 2 commits into
Open
SOLR-18417: Deprecate v1 PingRequestHandler and related code#4872gerlowskija wants to merge 2 commits into
gerlowskija wants to merge 2 commits into
Conversation
PingRequestHandler has largely been superseded by HealthcheckHandler (or
even SystemInfoHandler) which do healthchecks at the node-level instead
and tend to be much more compatible with typical load balancers.
This commit deprecates PingRequestHandler and the corresponding SolrPing
class in SolrJ. Removal will occur in a subsequent ('main'-only)
commit.
github-actions
Bot
added
documentation
gerlowskija
changed the title
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
PingRequestHandler has largely been superseded by HealthcheckHandler (or even SystemInfoHandler) which do healthchecks at the node-level instead and tend to be much more compatible with typical load balancers.
This commit deprecates PingRequestHandler and some related code, including the SolrPing and SolrPingResponse classes in SolrJ, and the
SolrClient.ping()methods on the SolrClient.Removal will be handled in a subsequent (main-only) PR.