Skip to content

Tracing & audit: HttpSolrCall.getQueryParams #4870

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
dsmiley wants to merge 2 commits into
base: main
Choose a base branch
from
+15 −1
Open

Tracing & audit: HttpSolrCall.getQueryParams #4870

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
707d215
Tracing & audit: HttpSolrCall.getQueryParams
dsmiley Sep 3, 2026
81cd9bc
changelog
dsmiley Sep 3, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
10 changes: 10 additions & 0 deletions changelog/unreleased/PR#4870-httpSolrCallGetQueryParams.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,10 @@
title: >
Distributed tracing and audit logging now see request parameters sent in a url-encoded POST body,
not only those in the URL query string.
type: changed
authors:
- name: David Smiley
- name: Xinyao Zhang
links:
- name: PR#4870
url: https://github.com/apache/solr/pull/4870
6 changes: 5 additions & 1 deletion solr/core/src/java/org/apache/solr/servlet/HttpSolrCall.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -201,8 +201,12 @@ public SolrCore getCore() {
return core;
}

/**
* If the request has been created, return its parameters (merges URL and body if applicable);
* otherwise, return only the URL query parameters.
*/
public SolrParams getQueryParams() {

@zhangxinyao88 zhangxinyao88 Sep 4, 2026

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

One thing to check: this also changes the V2 tracing golden output. TestDistributedTracing.testV2Api currently expects four post:/admin/cores spans, but reading the parsed POST params changes those to reload:/admin/cores. Could we update the golden file or add coverage here?

return queryParams;
return solrReq != null ? solrReq.getParams() : queryParams;
}

/** The collection(s) referenced in this request. Populated in {@link #init()}. Not null. */
Expand Down
Loading