Skip to content

SOLR-18304: Optimize collapse performance for String fields (branch_9x backport)#4635

Open
bartoszfidrysiak wants to merge 4 commits into
apache:branch_9xfrom
bartoszfidrysiak:SOLR-18304-collapse-string-sort-port-9
Open

SOLR-18304: Optimize collapse performance for String fields (branch_9x backport)#4635
bartoszfidrysiak wants to merge 4 commits into
apache:branch_9xfrom
bartoszfidrysiak:SOLR-18304-collapse-string-sort-port-9

Conversation

@bartoszfidrysiak

@bartoszfidrysiak bartoszfidrysiak commented Jul 14, 2026

Copy link
Copy Markdown
Contributor

https://issues.apache.org/jira/browse/SOLR-18304

Full description is present in the PR to main branch: #4621.
This PR contains cherry pick of 8088be23 commit from main branch and additionally two Solr 9 compatibility fixes:

  1. Got rid of pattern matching for instanceof because of using source java 11.
  2. Adjusted CollapsingSearch benchmark due to changes in Solr API.
  • I have reviewed the guidelines for How to Contribute and my code conforms to the standards described there to the best of my ability.
  • I have created a Jira issue and added the issue ID to my pull request title.
  • I have given Solr maintainers access to contribute to my PR branch. (optional but recommended, not available for branches on forks living under an organisation)
  • I have developed this patch against the main branch.
  • I have run ./gradlew check.
  • I have added tests for my changes.
  • I have added documentation for the Reference Guide
  • I have added a changelog entry for my change

)

Affects Solr 9.x and beyond.  As of Lucene 9 (technically late 8.x?), looking up a value became somewhat expensive, motivating being clever to avoid resolving the value.

(cherry picked from commit 8088be2)
@bartoszfidrysiak bartoszfidrysiak marked this pull request as ready for review July 14, 2026 08:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant