SOLR-18111: Remove deprecated field types (Legacy and Trie and BBox)#4145
Draft
epugh wants to merge 10 commits intoapache:mainfrom
Draft
SOLR-18111: Remove deprecated field types (Legacy and Trie and BBox)#4145epugh wants to merge 10 commits intoapache:mainfrom
epugh wants to merge 10 commits intoapache:mainfrom
Conversation
Very rough, but I did get a test to work.
With some caveats like some tests being commented out.
Contributor
Author
|
Now I am wondering why I thought BBoxField was deprecated (or maybe I thought it only worked with Trie?).. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
https://issues.apache.org/jira/browse/SOLR-18111
Description
I wanted to explore what it would mean to remove the legacy field types from our codebase.
Removing legacy field types also means removing Trie field types. I know that for certain highly specialized use cases Trie still has value to some people. So maybe we want to migrate it to it's own repo outside of Solr so that it doesn't impact all our code? Though of course making those interfaces will be fun! There is a lot of "if trie then".
My head has this as a Solr 11 change if we go forward.
I wanted to share this to see what the impact would be and if removing these things helps simplify our lives at all.
Solution
Removing code and working on the tests.
Tests
So many!