Skip to content

Comments

SOLR-18111: Remove deprecated field types (Legacy and Trie and BBox)#4145

Draft
epugh wants to merge 10 commits intoapache:mainfrom
epugh:SOLR-18111
Draft

SOLR-18111: Remove deprecated field types (Legacy and Trie and BBox)#4145
epugh wants to merge 10 commits intoapache:mainfrom
epugh:SOLR-18111

Conversation

@epugh
Copy link
Contributor

@epugh epugh commented Feb 18, 2026

https://issues.apache.org/jira/browse/SOLR-18111

Description

I wanted to explore what it would mean to remove the legacy field types from our codebase.

Removing legacy field types also means removing Trie field types. I know that for certain highly specialized use cases Trie still has value to some people. So maybe we want to migrate it to it's own repo outside of Solr so that it doesn't impact all our code? Though of course making those interfaces will be fun! There is a lot of "if trie then".

My head has this as a Solr 11 change if we go forward.

I wanted to share this to see what the impact would be and if removing these things helps simplify our lives at all.

Solution

Removing code and working on the tests.

  • Review commented out tests.
  • BBoxField, does it actually stay?
  • Finish simplifying schemas post trie removal
  • Ask claude to review tests for duplication between point and trie now that trie is gone.
  • Run some perf tests? Though for our generalized test suite I suspect we won't trigger the specific place trie does well.

Tests

So many!

Very rough, but I did get a test to work.
With some caveats like some tests being commented out.
@epugh
Copy link
Contributor Author

epugh commented Feb 19, 2026

Now I am wondering why I thought BBoxField was deprecated (or maybe I thought it only worked with Trie?)..

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant