SOLR-18099: CollapseQParser extensibility #4112
Open
+325
−371
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
And allow custom GroupHeadSelector building
github-actions
bot
added
documentation
mlbiscoc
approved these changes
Feb 12, 2026
| SORT, | ||
| SCORE; | ||
| SCORE, | ||
| CUSTOM; |
Contributor
There was a problem hiding this comment.
Maybe a point here that CUSTOM is specifically for subclasses? It's currently not used anywhere including tests and someone may remove it by mistake thinking no use.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
https://issues.apache.org/jira/browse/SOLR-18099
I did in a series of clean steps, separate commits.
BTW my approach was to take a custom subclass I have at work and put it in the source tree somewhere, and then iteratively made the refactorings (manually + IntelliJ refactorings) until the subclass compiled. I also made some tweaks to it. IntelliJ did the "record" conversion as well.
It's a shame this source file is so massive. Ideally we'd break it up at some point.
Also, the extensibility here is limited to String fields.