SOLR-15788 Remove configset/sample_techproducts_config from being used in unit tests#410
Closed
epugh wants to merge 10 commits intoapache:mainfrom
Closed
SOLR-15788 Remove configset/sample_techproducts_config from being used in unit tests#410epugh wants to merge 10 commits intoapache:mainfrom
epugh wants to merge 10 commits intoapache:mainfrom
Conversation
added 3 commits
November 10, 2021 16:25
added 7 commits
November 11, 2021 07:38
…TestBase legacyExampleCollection1SolrHome() now can pick between the old "techproducts", and the new only in solrj "testproducts" config, while I figure out if I can remove the use of legacyExampleCollection1SolrHome from the solr/core tests!
… need any special "techproducts" configs
… run use the standard collection1
…thChroot testBootstrapWithChroot was failing with the shorter setup, but seems to like the longer one. Not sure why.
…pleTests Just set this up on SolrExampleTests
… called "testproducts". Next step is to slim down the new "testproducts" to just what the tests need to pass, letting us change the old techproducts to be better at demoing features.
asfgit
pushed a commit
that referenced
this pull request
Dec 8, 2021
…akes test tasks always execute. (#410)
Contributor
Author
|
Closing in favour of #4147. Didn't quite get everything sorted that I wanted to, but 4147 is a big step forward. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
https://issues.apache.org/jira/browse/SOLR-15788
Description
Break link between our example configset and the run of the mill unit testing.
Solution
introduce a
solr/solrj/src/test-files/solrj/solr/testproductsconfigset based on the oldtechproductsconfigset, and then start removing files that aren't used by the solrj tests.Maybe it should be called
collection2instead?Tests
Running the unit tests.
Checklist
Please review the following and check all that apply:
mainbranch../gradlew check.