Skip to content

Use global.imagePullSecrets at solr-operator helm chart #338 #343

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
j-coll wants to merge 2 commits into
base: main
Choose a base branch
from
Open

Use global.imagePullSecrets at solr-operator helm chart #338 #343

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
e67c629
Use global.imagePullSecrets at solr-operator helm chart #338
j-coll Oct 13, 2021
b8bfd38
Merge branch 'apache:main' into main
j-coll Oct 13, 2021
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 4 additions & 0 deletions helm/solr-operator/templates/deployment.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -39,6 +39,10 @@ spec:
spec:
securityContext:
runAsNonRoot: true
{{- if .Values.global.imagePullSecrets }}
imagePullSecrets:
{{- toYaml .Values.global.imagePullSecrets | nindent 8 }}
Copy link
Contributor

@HoustonPutman HoustonPutman Oct 14, 2021

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Could you remove the first - here? We mainly aren't using that with toYamls in this file.

{{- end }}
serviceAccountName: {{ include "solr-operator.serviceAccountName" . }}
{{- if .Values.priorityClassName }}
priorityClassName: {{ .Values.priorityClassName }}
Expand Down
4 changes: 4 additions & 0 deletions helm/solr-operator/values.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -19,6 +19,10 @@

replicaCount: 1

global:
# Lists the secrets you need to use to pull solr-operator and zookeeper-operator images from a private registry.
imagePullSecrets: []

image:
repository: apache/solr-operator
tag: v0.5.0-prerelease
Expand Down