Skip to content

Fix Jetty client cannot receive the HTTP response body(#13500)#775

Merged
wu-sheng merged 4 commits intoapache:mainfrom
xhrg-join:main
Sep 26, 2025
Merged

Fix Jetty client cannot receive the HTTP response body(#13500)#775
wu-sheng merged 4 commits intoapache:mainfrom
xhrg-join:main

Conversation

@xhrg
Copy link
Contributor

@xhrg xhrg commented Sep 23, 2025 •
edited
Loading

  • If this pull request closes/resolves/fixes an existing issue, replace the issue number. Closes #13500.
  • Update the CHANGES log.

@xhrg xhrg mentioned this pull request Sep 23, 2025
Closed
3 tasks
wu-sheng
wu-sheng reviewed Sep 23, 2025
View reviewed changes
...n/java/org/apache/skywalking/apm/plugin/jetty/v9/client/AsyncHttpRequestSendInterceptor.java Outdated
allArguments[0] = new ResponseListenerWrapper(callback, ContextManager.capture());
return;
}
Response.CompleteListener callback = (Response.CompleteListener) allArguments[0];
Copy link
Member

@wu-sheng wu-sheng Sep 23, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Putting this in else should be better than adding a return in L64.

Copy link
Contributor Author

@xhrg xhrg Sep 23, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Completed

@wu-sheng
Copy link
Member

wu-sheng commented Sep 23, 2025

We need you to update the test scenarios, specific for which cases could cause previous issue.

@wu-sheng wu-sheng added enhancement New feature or request plugin labels Sep 23, 2025
@wu-sheng wu-sheng added this to the 9.6.0 milestone Sep 23, 2025
@wu-sheng wu-sheng linked an issue Sep 23, 2025 that may be closed by this pull request
[Bug] There is a bug in jetty in java-agent apache/skywalking#13500
Closed
3 tasks
@xhrg xhrg changed the title Fix Jetty client cannot receive the HTTP response body Fix Jetty client cannot receive the HTTP response body(#13500) Sep 23, 2025
@wu-sheng
Copy link
Member

wu-sheng commented Sep 23, 2025

Please fix the tests.

@wu-sheng
Copy link
Member

wu-sheng commented Sep 24, 2025

Error: src/main/java/org/apache/skywalking/apm/plugin/jetty/v90/client/ResponseListenerWrapper.java:[41,5] (whitespace) EmptyLineSeparator: 'METHOD_DEF' should be separated from previous line.
Error: Failed to execute goal org.apache.maven.plugins:maven-checkstyle-plugin:3.2.1:check (validate) on project apm-jetty-client-9.0-plugin: You have 1 Checkstyle violation. -> [Help 1]

Please fix.

@xhrg xhrg force-pushed the main branch 3 times, most recently from da529e7 to 17a0e59 Compare September 25, 2025 02:06
@wu-sheng wu-sheng merged commit bf2daf3 into apache:main Sep 26, 2025
198 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@wu-sheng wu-sheng wu-sheng approved these changes

Assignees

No one assigned

Labels

enhancement New feature or request plugin

Projects

None yet

Milestone

9.6.0

Development

Successfully merging this pull request may close these issues.

[Bug] There is a bug in jetty in java-agent

2 participants

@xhrg @wu-sheng