Conversation
wu-sheng
reviewed
Sep 5, 2025
| if (logs == null) { | ||
| logs = new LinkedList<>(); | ||
| } | ||
| if(logs.size() >= Config.Agent.LOG_LIMIT_PER_SPAN){ |
Member
There was a problem hiding this comment.
Please import the code sttyle, yours are not correct, CI will fail.
wu-sheng
reviewed
Sep 5, 2025
| @@ -36,6 +36,9 @@ agent.authentication=${SW_AGENT_AUTHENTICATION:} | |||
| # The max number of TraceSegmentRef in a single span to keep memory cost estimatable. | |||
| agent.trace_segment_ref_limit_per_span=${SW_TRACE_SEGMENT_LIMIT:500} | |||
|
|
|||
Member
There was a problem hiding this comment.
No point in adding this extra line.
wu-sheng
reviewed
Sep 5, 2025
CHANGES.md
Outdated
| * Bump up cli to the 0.15.0-dev.latest(77b4c49e89c9c000278f44e62729d534f2ec842e) in e2e. | ||
| * Bump up apache parent pom to v35. | ||
| * Update Maven to 3.6.3 in mvnw. | ||
| * Fix oom due to too many span log. |
Member
There was a problem hiding this comment.
Suggested change
| * Fix oom due to too many span log. | |
| * Fix OOM due to too many span logs. |
wu-sheng
approved these changes
Sep 5, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fix apache/skywalking#13472
Add a unit test to verify that the fix works.
Explain briefly why the bug exists and how to fix it.
If this pull request closes/resolves/fixes an existing issue, replace the issue number. Closes #<#13471>.
Update the
CHANGESlog.