bugfix(jakarta-ee): missing cache entry for the check - #2861
Open
lprimak wants to merge 1 commit into
Open
Conversation
lprimak
marked this pull request as draft
August 17, 2026 01:54
lprimak
force-pushed
the
add-form-cache-entry
branch
from
August 17, 2026 02:50
82a4ecf to
72e52d2
Compare
lprimak
marked this pull request as ready for review
August 17, 2026 02:51
lprimak
force-pushed
the
add-form-cache-entry
branch
from
August 17, 2026 03:19
bf42a47 to
a4eaccf
Compare
lprimak
force-pushed
the
add-form-cache-entry
branch
from
August 17, 2026 03:27
a4eaccf to
11d12a1
Compare
steinarb
reviewed
Aug 17, 2026
| Subject subject = methods.getSubject(request, response); | ||
| boolean isAuthenticated = subject.isAuthenticated() && subject.getPrincipal() != null; | ||
| return isAuthenticated || (useRemembered && subject.isRemembered()); | ||
| return isAuthenticated || (useRemembered && subject.isRemembered()) |
Contributor
There was a problem hiding this comment.
For logic like this, it would be nice to have a unit test targeting this code and triggering the NPE when the fix is not in place.
Contributor
There was a problem hiding this comment.
(or: if the NPE wasn't here, a test that replicates the NPE stack trace. I usually make such tests as simple as possible with as much mocking as possible, targeting own code)
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Recent fixes missed a code path, so NPE was found, This fixes it
Following this checklist to help us incorporate your contribution quickly and easily:
for the change (usually before you start working on it). Trivial changes like typos do not
require a GitHub issue. Your pull request should address just this issue, without pulling in other changes.
[#XXX] - Fixes bug in SessionManager,where you replace
#XXXwith the appropriate GitHub issue. Best practiceis to use the GitHub issue title in the pull request title and in the first line of the commit message.
fixes #XXXif merging the PR should close a related issue.mvn verifyto make sure basic checks pass. A more thorough check will be performed on your pull request automatically.Trivial changes like typos do not require a GitHub issue (javadoc, comments...).
In this case, just format the pull request title like
[DOC] - Add javadoc in SessionManager.If this is your first contribution, you have to read the Contribution Guidelines
If your pull request is about ~20 lines of code you don't need to sign an Individual Contributor License Agreement
if you are unsure please ask on the developers list.
To make clear that you license your contribution under the Apache License Version 2.0, January 2004
you have to acknowledge this by using the following check-box.