fix: register and clean up API runtime resources(#6716) - #7017
Open
juicewcode wants to merge 1 commit into
Open
Conversation
- After the API is created successfully, call the 'register' function to publish the associated selector/rule/metadata. - After the API is deleted successfully, call the 'removeRegister' function to clean up the associated runtime data. - When deleting by API path, the cleanup is executed synchronously. - Add protection for cases where extension data or context path is missing. - Add tests for API deletion cleanup and scenarios where the API does not exist.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #6716
Summary
registerafter a successful API creation so the related selector/rule/metadata data is published.removeRegisterafter successful API deletion.Test
testDeleteCleansRegisteredResourcesto verify rule, selector, and metadata cleanup.testDeleteWhenApiDoesNotExistto verify the expected missing-API response.Make sure that:
./mvnw clean install -Dmaven.javadoc.skip=true.