fix: correct namespace plugin name existence query(#6717) - #7016
Open
juicewcode wants to merge 1 commit into
Open
fix: correct namespace plugin name existence query(#6717)#7016juicewcode wants to merge 1 commit into
juicewcode wants to merge 1 commit into
Conversation
Modify the `namespace-plugin-rel-sqlmap.xml` file's `nameExistedExclude` query: - Associate `namespace_plugin_rel` with the `plugin` table. - Query the plugin name using `plugin.name`. - Add table aliases for `plugin_id` and `namespace_id` to avoid ambiguity in field names. Add Mapper test cases: - Verify that it returns true when the name matches. - Verify that it returns null when excluding the specified plugin. - Verify that it returns null when the name does not exist.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #6717
Summary
NamespacePluginRelMapper.nameExistedExclude, which queried thenon-existent
namecolumn fromnamespace_plugin_rel.plugintable and checksplugin.name.A mapper test was added to cover matching, excluded, and missing plugin names.
Test
true.null.null.Make sure that:
./mvnw clean install -Dmaven.javadoc.skip=true.