[type: bug] Fix session key mismatch in streamable HTTP transport (#6833) - #6997
Open
zhang-arvin wants to merge 1 commit into
Open
[type: bug] Fix session key mismatch in streamable HTTP transport (#6833)#6997zhang-arvin wants to merge 1 commit into
zhang-arvin wants to merge 1 commit into
Conversation
…ache#6833) Signed-off-by: zhang-arvin <arvin.zhang@htx-inc.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #6833
Problem
ShenyuStreamableHttpServerTransportProvider.handleInitializeRequestcreates aStreamableHttpSessionTransportwith auto-generated UUID as sessionId, but stores sessions underMcpServerSession.getId()(a different key). Whenclose()/closeGracefully()callsremoveSession(this.sessionId), it uses the auto-UUID, so nothing gets removed — sessions leak forever.Fix
After creating the session, sync the transport's sessionId to match the McpServerSession's ID via a new
setSessionId()method, ensuringclose()/closeGracefully()correctly removes the session.