Skip to content

[#4907] fixed servicecomb.credentials.akskEnabled set false cannot close log issue #5093

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
chengyouling merged 6 commits into from
Mar 6, 2026
Merged

[#4907] fixed servicecomb.credentials.akskEnabled set false cannot close log issue #5093

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
6 commits
Select commit Hold shift + click to select a range
d25359d
[#4907] fixed servicecomb.credentials.akskEnabled set false cannot cl…
chengyouling Mar 5, 2026
bceea13
change to jdk17.0.2
chengyouling Mar 5, 2026
eeb8091
change to jdk17.0.17
chengyouling Mar 5, 2026
81aebd9
change to jdk17.0.8
chengyouling Mar 6, 2026
bc779f0
change to eclipse-temurin:17-jre-jammy
chengyouling Mar 6, 2026
57e614e
change to eclipse-temurin:17-jre-jammy
chengyouling Mar 6, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion .github/workflows/maven.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -36,7 +36,7 @@ jobs:
- name: Set up jdk
uses: actions/setup-java@v5
with:
java-version: '17'
java-version: '17.0.8'
distribution: 'temurin'
- name: Set up Maven
uses: stCarolas/setup-maven@v5
Expand Down
2 changes: 1 addition & 1 deletion demo/demo-consul/consumer/pom.xml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -64,7 +64,7 @@
<name>${project.artifactId}:${project.version}</name>
<alias>${project.artifactId}</alias>
<build>
<from>openjdk:17.0.2</from>
<from>eclipse-temurin:17-jre-jammy</from>
<ports>
<port>7070</port>
<port>8080</port>
Expand Down
2 changes: 1 addition & 1 deletion demo/demo-consul/gateway/pom.xml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -67,7 +67,7 @@
<name>${project.artifactId}:${project.version}</name>
<alias>${project.artifactId}</alias>
<build>
<from>openjdk:17.0.2</from>
<from>eclipse-temurin:17-jre-jammy</from>
<ports>
<port>7070</port>
<port>8080</port>
Expand Down
2 changes: 1 addition & 1 deletion demo/demo-consul/provider/pom.xml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -74,7 +74,7 @@
<name>${project.artifactId}:${project.version}</name>
<alias>${project.artifactId}</alias>
<build>
<from>openjdk:17.0.2</from>
<from>eclipse-temurin:17-jre-jammy</from>
<ports>
<port>7070</port>
<port>8080</port>
Expand Down
2 changes: 1 addition & 1 deletion demo/demo-crossapp/crossapp-server/pom.xml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -58,7 +58,7 @@
<name>${project.artifactId}:${project.version}</name>
<alias>${project.artifactId}</alias>
<build>
<from>openjdk:17.0.2</from>
<from>eclipse-temurin:17-jre-jammy</from>
<ports>
<port>7070</port>
<port>8080</port>
Expand Down
2 changes: 1 addition & 1 deletion demo/demo-edge/authentication/pom.xml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -54,7 +54,7 @@
<name>${project.artifactId}:${project.version}</name>
<alias>${project.artifactId}</alias>
<build>
<from>openjdk:17.0.2</from>
<from>eclipse-temurin:17-jre-jammy</from>
<ports>
<port>7070</port>
<port>8080</port>
Expand Down
2 changes: 1 addition & 1 deletion demo/demo-edge/business-1-1-0/pom.xml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -60,7 +60,7 @@
<name>${project.artifactId}:${project.version}</name>
<alias>${project.artifactId}</alias>
<build>
<from>openjdk:17.0.2</from>
<from>eclipse-temurin:17-jre-jammy</from>
<ports>
<port>7070</port>
<port>8080</port>
Expand Down
2 changes: 1 addition & 1 deletion demo/demo-edge/business-1.0.0/pom.xml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -62,7 +62,7 @@
<name>${project.artifactId}:${project.version}</name>
<alias>${project.artifactId}</alias>
<build>
<from>openjdk:17.0.2</from>
<from>eclipse-temurin:17-jre-jammy</from>
<ports>
<port>7070</port>
<port>8080</port>
Expand Down
2 changes: 1 addition & 1 deletion demo/demo-edge/business-2.0.0/pom.xml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -62,7 +62,7 @@
<name>${project.artifactId}:${project.version}</name>
<alias>${project.artifactId}</alias>
<build>
<from>openjdk:17.0.2</from>
<from>eclipse-temurin:17-jre-jammy</from>
<ports>
<port>7070</port>
<port>8080</port>
Expand Down
2 changes: 1 addition & 1 deletion demo/demo-edge/edge-service/pom.xml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -60,7 +60,7 @@
<name>${project.artifactId}:${project.version}</name>
<alias>${project.artifactId}</alias>
<build>
<from>openjdk:17.0.2</from>
<from>eclipse-temurin:17-jre-jammy</from>
<ports>
<port>7070</port>
<port>8080</port>
Expand Down
2 changes: 1 addition & 1 deletion demo/demo-etcd/consumer/pom.xml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -74,7 +74,7 @@
<name>${project.artifactId}:${project.version}</name>
<alias>${project.artifactId}</alias>
<build>
<from>openjdk:17.0.2</from>
<from>eclipse-temurin:17-jre-jammy</from>
<ports>
<port>7070</port>
<port>8080</port>
Expand Down
2 changes: 1 addition & 1 deletion demo/demo-etcd/gateway/pom.xml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -73,7 +73,7 @@
<name>${project.artifactId}:${project.version}</name>
<alias>${project.artifactId}</alias>
<build>
<from>openjdk:17.0.2</from>
<from>eclipse-temurin:17-jre-jammy</from>
<ports>
<port>7070</port>
<port>8080</port>
Expand Down
2 changes: 1 addition & 1 deletion demo/demo-etcd/provider/pom.xml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -83,7 +83,7 @@
<name>${project.artifactId}:${project.version}</name>
<alias>${project.artifactId}</alias>
<build>
<from>openjdk:17.0.2</from>
<from>eclipse-temurin:17-jre-jammy</from>
<ports>
<port>7070</port>
<port>8080</port>
Expand Down
2 changes: 1 addition & 1 deletion demo/demo-filter/filter-client/pom.xml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -67,7 +67,7 @@
<name>${project.artifactId}:${project.version}</name>
<alias>${project.artifactId}</alias>
<build>
<from>openjdk:17.0.2</from>
<from>eclipse-temurin:17-jre-jammy</from>
<ports>
<port>7070</port>
<port>8080</port>
Expand Down
2 changes: 1 addition & 1 deletion demo/demo-filter/filter-edge/pom.xml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -71,7 +71,7 @@
<name>${project.artifactId}:${project.version}</name>
<alias>${project.artifactId}</alias>
<build>
<from>openjdk:17.0.2</from>
<from>eclipse-temurin:17-jre-jammy</from>
<ports>
<port>7070</port>
<port>8080</port>
Expand Down
2 changes: 1 addition & 1 deletion demo/demo-filter/filter-server/pom.xml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -62,7 +62,7 @@
<name>${project.artifactId}:${project.version}</name>
<alias>${project.artifactId}</alias>
<build>
<from>openjdk:17.0.2</from>
<from>eclipse-temurin:17-jre-jammy</from>
<ports>
<port>7070</port>
<port>8080</port>
Expand Down
2 changes: 1 addition & 1 deletion demo/demo-jaxrs/jaxrs-server/pom.xml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -72,7 +72,7 @@
<name>${project.artifactId}:${project.version}</name>
<alias>${project.artifactId}</alias>
<build>
<from>openjdk:17.0.2</from>
<from>eclipse-temurin:17-jre-jammy</from>
<ports>
<port>7070</port>
<port>8080</port>
Expand Down
2 changes: 1 addition & 1 deletion demo/demo-local-registry/demo-local-registry-server/pom.xml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -66,7 +66,7 @@
<name>${project.artifactId}:${project.version}</name>
<alias>${project.artifactId}</alias>
<build>
<from>openjdk:17.0.2</from>
<from>eclipse-temurin:17-jre-jammy</from>
<ports>
<port>7070</port>
<port>8080</port>
Expand Down
2 changes: 1 addition & 1 deletion demo/demo-multi-registries/demo-multi-registries-server/pom.xml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -66,7 +66,7 @@
<name>${project.artifactId}:${project.version}</name>
<alias>${project.artifactId}</alias>
<build>
<from>openjdk:17.0.2</from>
<from>eclipse-temurin:17-jre-jammy</from>
<ports>
<port>7070</port>
<port>8080</port>
Expand Down
2 changes: 1 addition & 1 deletion demo/demo-multi-service-center/demo-multi-service-center-serverA/pom.xml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -66,7 +66,7 @@
<name>${project.artifactId}:${project.version}</name>
<alias>${project.artifactId}</alias>
<build>
<from>openjdk:17.0.2</from>
<from>eclipse-temurin:17-jre-jammy</from>
<ports>
<port>7070</port>
<port>8080</port>
Expand Down
2 changes: 1 addition & 1 deletion demo/demo-multi-service-center/demo-multi-service-center-serverB/pom.xml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -66,7 +66,7 @@
<name>${project.artifactId}:${project.version}</name>
<alias>${project.artifactId}</alias>
<build>
<from>openjdk:17.0.2</from>
<from>eclipse-temurin:17-jre-jammy</from>
<ports>
<port>7070</port>
<port>8080</port>
Expand Down
2 changes: 1 addition & 1 deletion demo/demo-multiple/multiple-server/pom.xml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -65,7 +65,7 @@
<name>${project.artifactId}:${project.version}</name>
<alias>${project.artifactId}</alias>
<build>
<from>openjdk:17.0.2</from>
<from>eclipse-temurin:17-jre-jammy</from>
<ports>
<port>7070</port>
<port>8080</port>
Expand Down
2 changes: 1 addition & 1 deletion demo/demo-nacos/consumer/pom.xml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -64,7 +64,7 @@
<name>${project.artifactId}:${project.version}</name>
<alias>${project.artifactId}</alias>
<build>
<from>openjdk:17.0.2</from>
<from>eclipse-temurin:17-jre-jammy</from>
<ports>
<port>7070</port>
<port>8080</port>
Expand Down
2 changes: 1 addition & 1 deletion demo/demo-nacos/gateway/pom.xml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -67,7 +67,7 @@
<name>${project.artifactId}:${project.version}</name>
<alias>${project.artifactId}</alias>
<build>
<from>openjdk:17.0.2</from>
<from>eclipse-temurin:17-jre-jammy</from>
<ports>
<port>7070</port>
<port>8080</port>
Expand Down
2 changes: 1 addition & 1 deletion demo/demo-nacos/provider/pom.xml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -68,7 +68,7 @@
<name>${project.artifactId}:${project.version}</name>
<alias>${project.artifactId}</alias>
<build>
<from>openjdk:17.0.2</from>
<from>eclipse-temurin:17-jre-jammy</from>
<ports>
<port>7070</port>
<port>8080</port>
Expand Down
2 changes: 1 addition & 1 deletion demo/demo-pojo/pojo-server/pom.xml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -62,7 +62,7 @@
<name>${project.artifactId}:${project.version}</name>
<alias>${project.artifactId}</alias>
<build>
<from>openjdk:17.0.2</from>
<from>eclipse-temurin:17-jre-jammy</from>
<ports>
<port>7070</port>
<port>8080</port>
Expand Down
2 changes: 1 addition & 1 deletion demo/demo-register-url-prefix/demo-register-url-prefix-server/pom.xml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -61,7 +61,7 @@
<name>${project.artifactId}:${project.version}</name>
<alias>${project.artifactId}</alias>
<build>
<from>openjdk:17.0.2</from>
<from>eclipse-temurin:17-jre-jammy</from>
<ports>
<port>7070</port>
<port>8080</port>
Expand Down
2 changes: 1 addition & 1 deletion demo/demo-spring-boot-transport/demo-spring-boot-pojo-server/pom.xml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -63,7 +63,7 @@
<name>${project.artifactId}:${project.version}</name>
<alias>${project.artifactId}</alias>
<build>
<from>openjdk:17.0.2</from>
<from>eclipse-temurin:17-jre-jammy</from>
<ports>
<port>7070</port>
<port>8080</port>
Expand Down
2 changes: 1 addition & 1 deletion demo/demo-spring-boot-transport/demo-spring-boot-springmvc-server/pom.xml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -58,7 +58,7 @@
<name>${project.artifactId}:${project.version}</name>
<alias>${project.artifactId}</alias>
<build>
<from>openjdk:17.0.2</from>
<from>eclipse-temurin:17-jre-jammy</from>
<ports>
<port>7070</port>
<port>8080</port>
Expand Down
2 changes: 1 addition & 1 deletion demo/demo-springmvc/springmvc-server/pom.xml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -62,7 +62,7 @@
<name>${project.artifactId}:${project.version}</name>
<alias>${project.artifactId}</alias>
<build>
<from>openjdk:17.0.2</from>
<from>eclipse-temurin:17-jre-jammy</from>
<ports>
<port>7070</port>
<port>8080</port>
Expand Down
2 changes: 1 addition & 1 deletion demo/demo-zeroconfig-registry/demo-zeroconfig-registry-client/pom.xml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -73,7 +73,7 @@
<name>${project.artifactId}:${project.version}</name>
<alias>${project.artifactId}</alias>
<build>
<from>openjdk:17.0.2</from>
<from>eclipse-temurin:17-jre-jammy</from>
<ports>
<port>7070</port>
<port>8080</port>
Expand Down
2 changes: 1 addition & 1 deletion demo/demo-zeroconfig-registry/demo-zeroconfig-registry-edge/pom.xml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -78,7 +78,7 @@
<name>${project.artifactId}:${project.version}</name>
<alias>${project.artifactId}</alias>
<build>
<from>openjdk:17.0.2</from>
<from>eclipse-temurin:17-jre-jammy</from>
<ports>
<port>7070</port>
<port>8080</port>
Expand Down
2 changes: 1 addition & 1 deletion demo/demo-zeroconfig-registry/demo-zeroconfig-registry-server/pom.xml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -74,7 +74,7 @@
<name>${project.artifactId}:${project.version}</name>
<alias>${project.artifactId}</alias>
<build>
<from>openjdk:17.0.2</from>
<from>eclipse-temurin:17-jre-jammy</from>
<ports>
<port>7070</port>
<port>8080</port>
Expand Down
2 changes: 1 addition & 1 deletion demo/demo-zookeeper/consumer/pom.xml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -64,7 +64,7 @@
<name>${project.artifactId}:${project.version}</name>
<alias>${project.artifactId}</alias>
<build>
<from>openjdk:17.0.2</from>
<from>eclipse-temurin:17-jre-jammy</from>
<ports>
<port>7070</port>
<port>8080</port>
Expand Down
2 changes: 1 addition & 1 deletion demo/demo-zookeeper/gateway/pom.xml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -67,7 +67,7 @@
<name>${project.artifactId}:${project.version}</name>
<alias>${project.artifactId}</alias>
<build>
<from>openjdk:17.0.2</from>
<from>eclipse-temurin:17-jre-jammy</from>
<ports>
<port>7070</port>
<port>8080</port>
Expand Down
2 changes: 1 addition & 1 deletion demo/demo-zookeeper/provider/pom.xml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -76,7 +76,7 @@
<name>${project.artifactId}:${project.version}</name>
<alias>${project.artifactId}</alias>
<build>
<from>openjdk:17.0.2</from>
<from>eclipse-temurin:17-jre-jammy</from>
<ports>
<port>7070</port>
<port>8080</port>
Expand Down
11 changes: 4 additions & 7 deletions ...src/main/java/org/apache/servicecomb/huaweicloud/servicestage/AKSKAuthHeaderProvider.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -19,6 +19,7 @@

import java.net.URLEncoder;
import java.nio.charset.StandardCharsets;
import java.util.Collections;
import java.util.HashMap;
import java.util.List;
import java.util.Map;
Expand Down Expand Up @@ -65,25 +66,21 @@ public class AKSKAuthHeaderProvider implements AuthHeaderProvider, BootStrapServ

private final Map<String, String> headers = new HashMap<>();

private boolean enabled = true;

private boolean loaded = false;

public AKSKAuthHeaderProvider() {
}

public Map<String, String> authHeaders() {
if (enabled && !environment.getProperty(CONFIG_AKSK_ENABLED, boolean.class, true)) {
enabled = false;
return headers;
if (!environment.getProperty(CONFIG_AKSK_ENABLED, boolean.class, true)) {
return Collections.emptyMap();
}

if (StringUtils.isEmpty(getAccessKey())) {
LOGGER.warn("ak sk auth enabled but access key is not configured, disable it at runtime. "
+ "Config [{}] to false to disable it implicitly.",
CONFIG_AKSK_ENABLED);
enabled = false;
return headers;
return Collections.emptyMap();
}

if (!loaded) {
Expand Down
Loading