[GH-2798] Add ST_ShortestLine function#2806
Draft
jiayuasu wants to merge 1 commit intoapache:masterfrom
Draft
Conversation
c24dcaf to
8f82a05
Compare
8f82a05 to
6567332
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
ST_ShortestLine(geom1, geom2)function that returns the shortest LineString connecting two geometriesDistanceOp.nearestPoints()internally — same approach as the existingST_ClosestPointbut returns both endpoints as a LineString instead of a single Pointnullfor empty geometriesCloses #2798
Changes
Implementation (6 layers)
Functions.java):shortestLine(Geometry, Geometry)usingDistanceOpFunctions.scala):ST_ShortestLinecase classCatalog.scala): Function registrationst_functions.scala): Column/String wrappersst_functions.py): Python wrapperFunctions.java,Catalog.java): Flink scalar function + registrationTests
Documentation
Test plan
mvn test -pl common -Dtest="FunctionsTest#shortestLine*")