[GH-2744] Clean up Maven build logs by jiayuasu · Pull Request #2801 · apache/sedona

jiayuasu · 2026-03-29T06:43:06Z

Summary

Replace System.out.println with SLF4J/Log4j loggers across test and main source files to eliminate console noise during Maven builds
Raise test log4j2 root logger level from info to warn across all modules (common, spark, flink)
Fix Scala compiler warnings: remove redundant import, fix unreachable code, add missing match cases, fix uninitialized variable order

Test plan

Verify Maven build produces significantly fewer stdout log lines
Verify all existing tests still pass
Verify Scala compilation has no warnings

- Fix Scala compiler warnings: remove redundant import in Moran.scala, unreachable code in GeoParquetMetaData.scala, add missing match cases in BroadcastIndexJoinExec.scala and JoinQueryDetector.scala, fix uninitialized variable order in ScalaExample.scala - Replace System.out.println with SLF4J/Log4j loggers across test and main source files to eliminate console noise during builds - Raise test log4j2 root logger level from info to warn across all modules (common, spark, flink)

Copilot

Pull request overview

This PR reduces Maven build console noise by routing ad-hoc System.out output through logging frameworks and by raising test log levels, while also addressing several Scala compiler warnings (mostly around exhaustiveness/unreachable code).

Changes:

Raise test Log4j2 root logger level from info to warn across Spark/Flink/common modules.
Replace System.out.println/printf debug prints with SLF4J/Log4j logging across tests and example/demo code.
Fix Scala compiler warnings (e.g., missing match cases, redundant import, unreachable code cleanup).

Reviewed changes

Copilot reviewed 31 out of 31 changed files in this pull request and generated 4 comments.

Show a summary per file

File	Description
spark/spark-4.1/src/test/resources/log4j2.properties	Raise test root logging level to `warn`.
spark/spark-4.0/src/test/resources/log4j2.properties	Raise test root logging level to `warn`.
spark/spark-3.5/src/test/resources/log4j2.properties	Raise test root logging level to `warn`.
spark/spark-3.4/src/test/resources/log4j2.properties	Raise test root logging level to `warn`.
spark/common/src/test/resources/log4j2.properties	Raise test root logging level to `warn`.
spark/common/src/test/java/org/apache/sedona/viz/NYCTripPointMapper.java	Replace stdout printing with SLF4J logging in test helper.
spark/common/src/test/java/org/apache/sedona/core/spatialPartitioning/quadtree/RenderQuadTree.java	Replace stdout printing with SLF4J logging in test UI helper.
spark/common/src/main/scala/org/apache/spark/sql/sedona_sql/strategy/join/JoinQueryDetector.scala	Add missing match cases to remove Scala exhaustiveness warnings.
spark/common/src/main/scala/org/apache/spark/sql/sedona_sql/strategy/join/BroadcastIndexJoinExec.scala	Add missing match case to remove Scala warnings in plan string rendering.
spark/common/src/main/scala/org/apache/spark/sql/execution/datasources/geoparquet/GeoParquetMetaData.scala	Simplify `mapField` logic to avoid Scala warnings.
spark/common/src/main/scala/org/apache/sedona/viz/showcase/ScalaExample.scala	Reorder initialization and reduce direct stdout noise (still uses println).
spark/common/src/main/scala/org/apache/sedona/stats/autocorrelation/Moran.scala	Remove redundant import to fix Scala warning.
spark/common/src/main/scala/org/apache/sedona/core/showcase/ScalaExample.scala	Replace `System.out.println` with `println`.
spark/common/src/main/scala/org/apache/sedona/core/showcase/ScalaEarthdataMapperRunnableExample.scala	Replace `System.out.println` with `println`.
spark/common/src/main/java/org/apache/sedona/viz/showcase/Example.java	Replace stdout printing with Log4j logging in demo.
spark/common/src/main/java/org/apache/sedona/viz/extension/visualizationEffect/ChoroplethMap.java	Replace stdout printing with existing logger calls.
spark/common/src/main/java/org/apache/sedona/viz/core/ImageSerializableWrapper.java	Replace stdout printing with Log4j warning.
spark/common/src/main/java/org/apache/sedona/core/showcase/Example.java	Replace stdout printing with Log4j logging in demo.
spark/common/src/main/java/org/apache/sedona/core/showcase/EarthdataMapperRunnableExample.java	Replace stdout printing with Log4j logging in demo.
spark/common/src/main/java/org/apache/sedona/core/formatMapper/shapefileParser/ShapefileRDD.java	Replace stdout printing with SLF4J logging.
snowflake/src/main/java/org/apache/sedona/snowflake/snowsql/ddl/DDLGenerator.java	Replace stdout printing with SLF4J logging for CLI usage + DDL output.
snowflake-tester/src/test/java/org/apache/sedona/snowflake/snowsql/TestBase.java	Replace stdout printing with test logger output.
snowflake-tester/src/test/java/org/apache/sedona/snowflake/snowsql/SnowTestRunner.java	Replace stdout printing with SLF4J logging.
snowflake-tester/src/test/java/org/apache/sedona/snowflake/snowsql/SnowClient.java	Replace stdout printing with structured logger output.
flink/src/test/resources/log4j2.properties	Raise test root logging level to `warn`.
flink/src/test/java/org/apache/sedona/flink/FunctionTest.java	Replace stdout printing with SLF4J debug logging.
common/src/test/resources/log4j2.properties	Raise test root logging level to `warn`.
common/src/test/java/org/apache/sedona/common/geometrySerde/SpatialIndexSerdeTest.java	Replace stdout printing with SLF4J logging in tests.
common/src/test/java/org/apache/sedona/common/S2Geography/TestHelper.java	Replace stdout printing with SLF4J debug logging.
common/src/test/java/org/apache/sedona/common/FunctionsTest.java	Replace stdout printing with SLF4J debug logging.
common/src/test/java/org/apache/sedona/common/FunctionsProj4PerformanceTest.java	Replace stdout/printf with SLF4J logging in performance tests.

Comments suppressed due to low confidence (1)

spark/common/src/main/scala/org/apache/sedona/viz/showcase/ScalaExample.scala:52

ConfFile is a FileInputStream that is repeatedly reassigned and passed to prop.load(...) but never closed. This can leak file descriptors in long-running demo runs; consider using a scoped resource pattern (e.g., scala.util.Using) or explicitly closing the stream after each prop.load.

  val resourcePath = "/../spark/common/src/test/resources/"
  var ConfFile = new FileInputStream(resourcePath + "babylon.point.properties")
  val demoOutputPath = "target/demo"
  val scatterPlotOutputPath =
    System.getProperty("user.dir") + "/" + demoOutputPath + "/scatterplot"
  prop.load(ConfFile)
  val heatMapOutputPath = System.getProperty("user.dir") + "/" + demoOutputPath + "/heatmap"

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

snowflake/src/main/java/org/apache/sedona/snowflake/snowsql/ddl/DDLGenerator.java

- Revert DDL SQL output lines back to System.out.println since the tool is used with stdout redirection (java -jar ... > sedona-snowflake.sql) - Replace assert with explicit check for required geotools-version arg (assertions are disabled by default without -ea) - Fix usage text: --h -> -h to match the actual argument parser

The snowflake DDLGenerator is a CLI tool that outputs SQL to stdout for file redirection. All println usage in snowflake and snowflake-tester should remain unchanged.

Copilot

Pull request overview

Copilot reviewed 27 out of 27 changed files in this pull request and generated 4 comments.

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

common/src/test/java/org/apache/sedona/common/S2Geography/TestHelper.java

spark/common/src/main/scala/org/apache/sedona/viz/showcase/ScalaExample.scala

spark/common/src/main/scala/org/apache/sedona/core/showcase/ScalaExample.scala

...mon/src/main/scala/org/apache/sedona/core/showcase/ScalaEarthdataMapperRunnableExample.scala

compareTo(geoWKT, geoWKT) was comparing the same object, making the assertion always pass. Changed to compareTo(geoWKB, geoWKT).

Copilot

Pull request overview

Copilot reviewed 27 out of 27 changed files in this pull request and generated 2 comments.

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

...on/src/main/scala/org/apache/spark/sql/sedona_sql/strategy/join/BroadcastIndexJoinExec.scala

.../common/src/main/scala/org/apache/spark/sql/sedona_sql/strategy/join/JoinQueryDetector.scala

Replace placeholder match arms with explicit exceptions: - Raster + distance: createStreamShapes deserializes as geometry, would fail on raster bytes - Geography + non-raster: not yet implemented - Geography + raster: not yet implemented

Copilot

Pull request overview

Copilot reviewed 27 out of 27 changed files in this pull request and generated 4 comments.

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

common/src/test/java/org/apache/sedona/common/FunctionsProj4PerformanceTest.java

...k/common/src/main/java/org/apache/sedona/core/formatMapper/shapefileParser/ShapefileRDD.java

common/src/test/java/org/apache/sedona/common/FunctionsProj4PerformanceTest.java

The compareTo(geoWKT, geoWKT) bug masks a deeper issue: WKB and WKT readers produce incompatible Geography types for empty geometries, causing compareTo to fail. Reverting to unblock CI; tracked in a separate issue.

jiayuasu requested a review from Copilot March 29, 2026 06:51

jiayuasu marked this pull request as draft March 29, 2026 06:51

Copilot started reviewing on behalf of jiayuasu March 29, 2026 06:51 View session

Copilot AI reviewed Mar 29, 2026

View reviewed changes

jiayuasu added 2 commits March 29, 2026 00:42

Revert all snowflake module changes

8331aa9

The snowflake DDLGenerator is a CLI tool that outputs SQL to stdout for file redirection. All println usage in snowflake and snowflake-tester should remain unchanged.

jiayuasu requested a review from Copilot March 29, 2026 22:02

Copilot started reviewing on behalf of jiayuasu March 29, 2026 22:02 View session

Copilot AI reviewed Mar 29, 2026

View reviewed changes

Fix bug in checkWKBGeography: compare geoWKB against geoWKT

bc4385a

compareTo(geoWKT, geoWKT) was comparing the same object, making the assertion always pass. Changed to compareTo(geoWKB, geoWKT).

jiayuasu requested a review from Copilot March 29, 2026 22:33

Copilot started reviewing on behalf of jiayuasu March 29, 2026 22:34 View session

Copilot AI reviewed Mar 29, 2026

View reviewed changes

...on/src/main/scala/org/apache/spark/sql/sedona_sql/strategy/join/BroadcastIndexJoinExec.scala Show resolved Hide resolved

.../common/src/main/scala/org/apache/spark/sql/sedona_sql/strategy/join/JoinQueryDetector.scala Show resolved Hide resolved

jiayuasu requested a review from Copilot March 30, 2026 06:13

jiayuasu mentioned this pull request Mar 30, 2026

Support distance joins for raster predicates #2809

Open

Copilot started reviewing on behalf of jiayuasu March 30, 2026 06:14 View session

Copilot AI reviewed Mar 30, 2026

View reviewed changes

jiayuasu added 2 commits March 29, 2026 23:25

Revert checkWKBGeography fix, tracked separately

f6d2627

The compareTo(geoWKT, geoWKT) bug masks a deeper issue: WKB and WKT readers produce incompatible Geography types for empty geometries, causing compareTo to fail. Reverting to unblock CI; tracked in a separate issue.

Fix Spotless formatting for exception strings

9d46a0e

jiayuasu marked this pull request as ready for review March 30, 2026 06:51

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

[GH-2744] Clean up Maven build logs#2801

[GH-2744] Clean up Maven build logs#2801
jiayuasu wants to merge 7 commits intoapache:masterfrom
jiayuasu:fix/clean-maven-build-logs

jiayuasu commented Mar 29, 2026

Uh oh!

Copilot AI left a comment

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Copilot AI left a comment

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Copilot AI left a comment

Uh oh!

Uh oh!

Uh oh!

Copilot AI left a comment

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

2 participants

Conversation

jiayuasu commented Mar 29, 2026

Summary

Test plan

Uh oh!

Copilot AI left a comment

Choose a reason for hiding this comment

Pull request overview

Reviewed changes

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Copilot AI left a comment

Choose a reason for hiding this comment

Pull request overview

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Copilot AI left a comment

Choose a reason for hiding this comment

Pull request overview

Uh oh!

Uh oh!

Uh oh!

Copilot AI left a comment

Choose a reason for hiding this comment

Pull request overview

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

2 participants