Clear local logged stores if input checkpoints are empty#1713
Merged
ajothomas merged 1 commit intoapache:masterfrom Dec 19, 2024
Merged
Clear local logged stores if input checkpoints are empty#1713ajothomas merged 1 commit intoapache:masterfrom
ajothomas merged 1 commit intoapache:masterfrom
Conversation
xinyuiscool
reviewed
Dec 18, 2024
samza-core/src/main/scala/org/apache/samza/storage/ContainerStorageManager.java
Outdated
Show resolved
Hide resolved
xinyuiscool
approved these changes
Dec 18, 2024
Contributor
xinyuiscool
left a comment
There was a problem hiding this comment.
LGTM. One minor style fix.
ea4ec8c to
f9e367a
Compare
f9e367a to
4e4509f
Compare
xinyuiscool
approved these changes
Dec 19, 2024
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Symptom:
If an external utility attempts to reset a job's state by clearing backups and checkpoints, the local state still remains. We need to clear the local rocksdb state of stateful jobs, if the inputs checkpoints don't exist.
Changes:
Tests:
TestContainerStorageManagerto verify that stores are deleted from logged store dir on empty checkpointsAPI Changes:
None
Upgrade Instructions:
None
Usage Instructions:
None