Open
Conversation
Contributor
cameronlee314
left a comment
cameronlee314
left a comment
There was a problem hiding this comment.
Thanks for the change. I just had a couple of minor questions.
build.gradle
Outdated
Comment on lines
105
to
108
| tasks.withType(JavaCompile).configureEach { | ||
| options.fork = true | ||
| } | ||
|
|
Contributor
There was a problem hiding this comment.
Minor: Could you please use 2 spaces for indentation instead of 4? Just for consistency with the rest of the file.
Contributor
|
@cameronlee314 any reason not to merge this one? |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Compiler daemon. The Gradle Java plugin allows you to run the compiler as a separate process by setting
options.fork = true. This feature can lead to much less garbage collection and make Gradle’s infrastructure faster. This project has more than 1000 source files. We can consider enabling this feature.=====================
If there are any inappropriate modifications in this PR, please give me a reply and I will change them.