Fix CID_DefaultHeartBeatSyncerTopic not created when autoCreateSubscriptionGroup is false.#9967
Open
1782935682 wants to merge 1 commit intoapache:developfrom
Open
Fix CID_DefaultHeartBeatSyncerTopic not created when autoCreateSubscriptionGroup is false.#99671782935682 wants to merge 1 commit intoapache:developfrom
1782935682 wants to merge 1 commit intoapache:developfrom
Conversation
…ubscriptionGroup is false.
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## develop #9967 +/- ##
=============================================
- Coverage 48.81% 48.71% -0.11%
+ Complexity 12763 12742 -21
=============================================
Files 1324 1324
Lines 96407 96445 +38
Branches 12435 12442 +7
=============================================
- Hits 47064 46982 -82
- Misses 43600 43706 +106
- Partials 5743 5757 +14 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Which Issue(s) This PR Fixes
The HeartbeatSyncer in Proxy relies on the Broker to automatically create the internal consumer group (CID_DefaultHeartBeatSyncerTopic). If autoCreateSubscriptionGroup is set to false on the Broker, the Syncer fails to start because the group does not exist.
Brief Description
How Did You Test This Change?