Skip to content

[ISSUE #10989] Fix transactional message escape retry backoff (2 ^ n computed with XOR) #10993

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
unbridled-41 wants to merge 1 commit into
base: develop
Choose a base branch
from
+12 −1
Open

[ISSUE #10989] Fix transactional message escape retry backoff (2 ^ n computed with XOR) #10993

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 5 additions & 1 deletion ...in/java/org/apache/rocketmq/broker/transaction/queue/TransactionalMessageServiceImpl.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -61,6 +61,10 @@ public class TransactionalMessageServiceImpl implements TransactionalMessageServ
private static final int MAX_PROCESS_TIME_LIMIT = 60000;
private static final int MAX_RETRY_TIMES_FOR_ESCAPE = 10;

static long escapeRetryBackoffMillis(int escapeFailCnt) {
return 100L * (1 << escapeFailCnt);
}

private static final int MAX_RETRY_COUNT_WHEN_HALF_NULL = 1;

private static final int OP_MSG_PULL_NUMS = 32;
Expand Down Expand Up @@ -250,7 +254,7 @@ public void check(long transactionTimeout, int transactionCheckMax,
msgExt.getUserProperty(MessageConst.PROPERTY_UNIQ_CLIENT_MESSAGE_ID_KEYIDX));
if (escapeFailCnt < MAX_RETRY_TIMES_FOR_ESCAPE) {
escapeFailCnt++;
Thread.sleep(100L * (2 ^ escapeFailCnt));
Thread.sleep(escapeRetryBackoffMillis(escapeFailCnt));
} else {
escapeFailCnt = 0;
newOffset = i + 1;
Expand Down
7 changes: 7 additions & 0 deletions ...ava/org/apache/rocketmq/broker/transaction/queue/TransactionalMessageServiceImplTest.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -84,6 +84,13 @@ public void init() {
queueTransactionMsgService = new TransactionalMessageServiceImpl(bridge);
}

@Test
public void testEscapeRetryBackoffMillisIsExponential() {
for (int i = 1; i <= 10; i++) {
assertThat(TransactionalMessageServiceImpl.escapeRetryBackoffMillis(i)).isEqualTo(100L * (1L << i));
}
}

@Test
public void testPrepareMessage() {
MessageExtBrokerInner inner = createMessageBrokerInner();
Expand Down