Skip to content

[ISSUE #10181] Remove lock when resetting offset in PopConsumerService#10250

Merged
lizhimins merged 1 commit intoapache:developfrom
lizhimins:zhimin/remove-lock
Apr 10, 2026
Merged

[ISSUE #10181] Remove lock when resetting offset in PopConsumerService#10250
lizhimins merged 1 commit intoapache:developfrom
lizhimins:zhimin/remove-lock

Conversation

@lizhimins
Copy link
Copy Markdown
Member

Which Issue(s) This PR Fixes

Brief Description

How Did You Test This Change?

…vice (apache#10182)

Signed-off-by: terrance.lzm <terrance.lzm@alibaba-inc.com>
@codecov-commenter
Copy link
Copy Markdown

Codecov Report

❌ Patch coverage is 50.00000% with 1 line in your changes missing coverage. Please review.
✅ Project coverage is 48.86%. Comparing base (2b5e709) to head (cdeb9a4).

Files with missing lines Patch % Lines
...apache/rocketmq/broker/pop/PopConsumerService.java 50.00% 0 Missing and 1 partial ⚠️
Additional details and impacted files
@@              Coverage Diff              @@
##             develop   #10250      +/-   ##
=============================================
- Coverage      49.00%   48.86%   -0.14%     
+ Complexity     13462    13425      -37     
=============================================
  Files           1375     1375              
  Lines         100397   100394       -3     
  Branches       12965    12964       -1     
=============================================
- Hits           49195    49058     -137     
- Misses         45213    45319     +106     
- Partials        5989     6017      +28     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

Copy link
Copy Markdown
Contributor

@lollipopjin lollipopjin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@lizhimins lizhimins changed the title [ISSUE #10181] Remove lock when reset offset for PopConsumerService [ISSUE #10181] Remove lock when resetting offset in PopConsumerService Apr 10, 2026
@lizhimins lizhimins merged commit b8aba3b into apache:develop Apr 10, 2026
11 of 17 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

[Enhancement] Some minor fixes in PopConsumerService

3 participants