RATIS-2699. zizmor-action upgrade may break silently - #1594
Open
adoroszlai wants to merge 1 commit into
Open
adoroszlai wants to merge 1 commit into
adoroszlai wants to merge 1 commit into
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What changes were proposed in this pull request?
Similar to apache/ratis-thirdparty#195, except the workflow fixes to satisfy new
zizmor-actionrules, since it is not upgraded to 0.6.4 inratisyet.Rules introduced by new versions may fail silently in the PR that bumps zizmor-action (problem is reported in details, but check still passes). The failure will surface only in forks or in PRs changing the offending workflow files.
With GitHub Advanced Security (the default) problems are reported in the repo's Code scanning page. When this feature is disabled, any problems reported cause the check to fail.
This change keeps Advanced Security only for push events in Apache repo, which allows pull requests touching only
zizmor.yaml(e.g. for version bump) to catch problems in other files.https://issues.apache.org/jira/browse/RATIS-2699
How was this patch tested?
zizmor check in fork:
https://github.com/adoroszlai/ratis/actions/runs/35078871951