RATIS-2694. Log last gRPC stream reply in GrpcServerProtocolService completion message - #1588
Open
jojochuang wants to merge 1 commit into
Open
jojochuang wants to merge 1 commit into
jojochuang wants to merge 1 commit into
Conversation
…ompletion message Ordered ServerRequestStreamObserver requests (including INSTALL_SNAPSHOT) send each reply on the stream but complete the internal future with null. Record the last reply sent on the stream and log it via replyToString on stream completion instead of ProtoUtils.shortDebugString(null). Co-authored-by: Cursor <cursoragent@cursor.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
ServerRequestStreamObserverwithreplyInOrder == true, including INSTALL_SNAPSHOT), each reply is sent on the stream inonNext, but the internalCompletableFuturechain completes withnull.onCompletedloggedProtoUtils.shortDebugString(reply)and therefore always showedlastReply: null, which is misleading during snapshot catch-up.replyToStringon stream completion (fallback to the future value for unordered requests, ornone).Jira
https://issues.apache.org/jira/browse/RATIS-2694
Test plan
mvn -pl ratis-grpc -am test -DskipTestsCompleted INSTALL_SNAPSHOT, lastReply:should match the lastreply installSnapshot:line fromSnapshotInstallationHandlerMade with Cursor