RATIS-2311. Control appliedIndex before starting a transfer election - #1586
Open
Elia-Renzoni wants to merge 1 commit into
Open
Elia-Renzoni wants to merge 1 commit into
Elia-Renzoni wants to merge 1 commit into
Conversation
Signed-off-by: Elia Renzoni <elia.renzoni03@gmail.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What changes were proposed in this pull request?
This PR makes the leadership transfer check in TransferLeadership#isFollowerUpToDate stricter by also verifying that the gap between the target follower's matchIndex (replicated log) and its appliedIndex (state machine apply progress) is within an acceptable threshold, in addition to the existing matchIndex up-to-date check
What is the link to the Apache JIRA
https://issues.apache.org/jira/browse/RATIS-2311?page=com.atlassian.jira.plugin.system.issuetabpanels%3Aall-tabpanel
How was this patch tested?
Added
testRiskyLeadershipTransferto the abstractLeaderElectionTestsclass, alongside the existingtestTransferLeaderandtestTransferLeaderTimeouttests