[improve][broker] Expose interface for the replicator in ManagedLedger instead of cast the class - #26298
Open
zymap wants to merge 2 commits into
Open
[improve][broker] Expose interface for the replicator in ManagedLedger instead of cast the class#26298zymap wants to merge 2 commits into
zymap wants to merge 2 commits into
Conversation
lhotari
reviewed
Aug 10, 2026
|
|
||
| @Override | ||
| public void scheduleReadCallback(Runnable callback, long delay, TimeUnit unit) { | ||
| ledger.getScheduledExecutor().schedule(() -> ledger.getExecutor().execute(callback), delay, unit); |
Member
There was a problem hiding this comment.
It could be useful to wrap the Runnable passed to .schedule with org.apache.pulsar.common.util.Runnables.catchingAndLoggingThrowables so that possible runtime exceptions would get logged.
lhotari
reviewed
Aug 10, 2026
| * @param unit the time unit of the delay | ||
| */ | ||
| default void scheduleReadCallback(Runnable callback, long delay, TimeUnit unit) { | ||
| CompletableFuture.delayedExecutor(delay, unit).execute(callback); |
Member
There was a problem hiding this comment.
It could be useful to wrap callback with org.apache.pulsar.common.util.Runnables.catchingAndLoggingThrowables so that runtime exceptions get logged.
lhotari
approved these changes
Aug 10, 2026
lhotari
left a comment
lhotari
left a comment
Member
There was a problem hiding this comment.
LGTM, just 2 suggestions to improve logging for failure cases.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #xyz
Main Issue: #xyz
PIP: #xyz
Motivation
Managed-ledger callers should depend on the ManagedLedger and ManagedCursor interfaces instead of concrete implementations. The newly added retry logic cast the ledger to ManagedLedgerImpl, causing a ClassCastException for custom managed-ledger implementations.
Modifications
Added ManagedCursor.scheduleReadCallback(...) as a backward-compatible interface method.
Overrode it in ManagedCursorImpl to preserve the existing managed-ledger scheduler and executor behavior.
Updated PersistentReplicator to use the interface method without casting to ManagedLedgerImpl.
Verifying this change
(Please pick either of the following options)
This change is a trivial rework / code cleanup without any test coverage.
(or)
This change is already covered by existing tests, such as (please describe tests).
(or)
This change added tests and can be verified as follows:
(example:)
Does this pull request potentially affect one of the following parts:
If the box was checked, please highlight the changes