[improve] replace jcip annotations to jsr305 annotations

[sindhushreem25]

Removal of jcip and moving to spotbugs and javax annotations.

Fixes #xyz

Main Issue: #xyz

PIP: #xyz

Motivation

Modifications

Verifying this change

• Make sure that the change passes the CI checks.

(Please pick either of the following options)

This change is a trivial rework / code cleanup without any test coverage.

(or)

This change is already covered by existing tests, such as (please describe tests).

(or)

This change added tests and can be verified as follows:

(example:)

• Added integration tests for end-to-end deployment with large payloads (10MB)
• Extended integration test for recovery after broker failure

Does this pull request potentially affect one of the following parts:

If the box was checked, please highlight the changes

• Dependencies (add or upgrade a dependency)
• The public API
• The schema
• The default values of configurations
• The threading model
• The binary protocol
• The REST endpoints
• The admin CLI options
• The metrics
• Anything that affects deployment

Documentation

• doc
• doc-required
• doc-not-needed
• doc-complete

Matching PR in forked repository

PR in forked repository:

[github-actions]

@sindhushreem25 Please add the following content to your PR description and select a checkbox:

- [ ] `doc` <!-- Your PR contains doc changes -->
- [ ] `doc-required` <!-- Your PR changes impact docs and you will update later -->
- [ ] `doc-not-needed` <!-- Your PR changes do not impact docs -->
- [ ] `doc-complete` <!-- Docs have been already added -->

[lhotari]

I checked once more and noticed that spotbugs-annotations doesn't contain the annotations. This is what spotbugs-annotations depends on:

    <dependency>
      <groupId>com.google.code.findbugs</groupId>
      <artifactId>jsr305</artifactId>
      <version>3.0.2</version>
      <scope>compile</scope>
    </dependency>

Please switch to use this dependency directly.

Since javax.annotation is already relocated, there's no need to add entries for that part.

[sindhushreem25]

resolved the comments

[lhotari]

LGTM

[codecov-commenter]

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 72.61%. Comparing base (436ca72) to head (8dd8d4c).
⚠️ Report is 2 commits behind head on master.

Additional details and impacted files

@@             Coverage Diff              @@
##             master   #25252      +/-   ##
============================================
- Coverage     72.95%   72.61%   -0.35%     
+ Complexity    34171    33996     -175     
============================================
  Files          1959     1959              
  Lines        155401   155403       +2     
  Branches      17724    17726       +2     
============================================
- Hits         113380   112850     -530     
- Misses        33116    33536     +420     
- Partials       8905     9017     +112     

Flag	Coverage Δ
inttests	25.66% <ø> (-0.41%)	⬇️
systests	22.34% <ø> (-0.26%)	⬇️
unittests	73.58% <ø> (-0.34%)	⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Files with missing lines	Coverage Δ
...va/org/apache/pulsar/client/impl/MessagesImpl.java	76.92% <ø> (ø)

... and 126 files with indirect coverage changes

🚀 New features to boost your workflow:

• ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
• 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

[sindhushreem25]

@lhotari should i change the dependency which are failing in OWASP Dependency-Check